Title: [235377] trunk/Source/WebInspectorUI
- Revision
- 235377
- Author
- drou...@apple.com
- Date
- 2018-08-27 09:59:39 -0700 (Mon, 27 Aug 2018)
Log Message
Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
https://bugs.webkit.org/show_bug.cgi?id=188959
Reviewed by Brian Burg.
* UserInterface/Views/TreeElement.js:
(WI.TreeElement.prototype.set hidden):
Only set `focusedTreeElement` if the `WI.TreeElement` is selected and not hidden. There is
no reason to focus a hidden or unselected `WI.TreeElement`.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (235376 => 235377)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-27 16:59:32 UTC (rev 235376)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-27 16:59:39 UTC (rev 235377)
@@ -1,3 +1,15 @@
+2018-08-27 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: REGRESSION: virtualized TreeOutline is empty when filtering
+ https://bugs.webkit.org/show_bug.cgi?id=188959
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/TreeElement.js:
+ (WI.TreeElement.prototype.set hidden):
+ Only set `focusedTreeElement` if the `WI.TreeElement` is selected and not hidden. There is
+ no reason to focus a hidden or unselected `WI.TreeElement`.
+
2018-08-23 Devin Rousso <drou...@apple.com>
Web Inspector: Color picker: can't enter decimal numbers for opacity
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (235376 => 235377)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-08-27 16:59:32 UTC (rev 235376)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-08-27 16:59:39 UTC (rev 235377)
@@ -166,7 +166,10 @@
this._childrenListNode.hidden = this._hidden;
if (this.treeOutline) {
- this.treeOutline.soon.updateVirtualizedElements(this);
+ let focusedTreeElement = null;
+ if (!this._hidden && this.selected)
+ focusedTreeElement = this;
+ this.treeOutline.soon.updateVirtualizedElements(focusedTreeElement);
this.treeOutline.dispatchEventToListeners(WI.TreeOutline.Event.ElementVisibilityDidChange, {element: this});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
