Title: [235404] trunk/Tools
- Revision
- 235404
- Author
- [email protected]
- Date
- 2018-08-27 15:19:52 -0700 (Mon, 27 Aug 2018)
Log Message
Partial revert of r235376
https://bugs.webkit.org/show_bug.cgi?id=189011
For now revert the unit tests added in r235376 as the following tests are failing on Apple Sierra
Debug and Apple High Sierra Debug bots:
lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_simple
lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple
Will investigate offline.
* lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
* lldb/lldb_webkit_unittest.py:
(TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
(TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty): Deleted.
(TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple): Deleted.
(TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Deleted.
(TestSummaryProviders.serial_test_WTFOptionSetProvider_simple): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235403 => 235404)
--- trunk/Tools/ChangeLog 2018-08-27 21:48:13 UTC (rev 235403)
+++ trunk/Tools/ChangeLog 2018-08-27 22:19:52 UTC (rev 235404)
@@ -1,3 +1,25 @@
+2018-08-27 Daniel Bates <[email protected]>
+
+ Partial revert of r235376
+ https://bugs.webkit.org/show_bug.cgi?id=189011
+
+ For now revert the unit tests added in r235376 as the following tests are failing on Apple Sierra
+ Debug and Apple High Sierra Debug bots:
+
+ lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_simple
+ lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple
+
+ Will investigate offline.
+
+ * lldb/lldbWebKitTester/main.cpp:
+ (testSummaryProviders):
+ * lldb/lldb_webkit_unittest.py:
+ (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
+ (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty): Deleted.
+ (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple): Deleted.
+ (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Deleted.
+ (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple): Deleted.
+
2018-08-27 Aditya Keerthi <[email protected]>
Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
Modified: trunk/Tools/lldb/lldbWebKitTester/main.cpp (235403 => 235404)
--- trunk/Tools/lldb/lldbWebKitTester/main.cpp 2018-08-27 21:48:13 UTC (rev 235403)
+++ trunk/Tools/lldb/lldbWebKitTester/main.cpp 2018-08-27 22:19:52 UTC (rev 235404)
@@ -27,7 +27,6 @@
#include <stdio.h>
#include <wtf/HashMap.h>
#include <wtf/HashSet.h>
-#include <wtf/OptionSet.h>
#include <wtf/Vector.h>
#include <wtf/text/StringBuilder.h>
#include <wtf/text/WTFString.h>
@@ -45,13 +44,6 @@
return builder.toString();
}
-enum class ExampleFlags {
- A = 1 << 0,
- B = 1 << 1,
- C = 1 << 2,
- D = 1 << 3,
-};
-
static void testSummaryProviders()
{
String aNullString { "" };
@@ -81,9 +73,6 @@
HashMap<unsigned, Vector<int>> hashMapOfVectors;
hashMapOfVectors.add(1, Vector<int>({2, 3}));
- OptionSet<ExampleFlags> exampleFlagsEmpty;
- OptionSet<ExampleFlags> exampleFlagsSimple { ExampleFlags::A, ExampleFlags::D, ExampleFlags::C };
-
breakForTestingSummaryProviders();
}
Modified: trunk/Tools/lldb/lldb_webkit_unittest.py (235403 => 235404)
--- trunk/Tools/lldb/lldb_webkit_unittest.py 2018-08-27 21:48:13 UTC (rev 235403)
+++ trunk/Tools/lldb/lldb_webkit_unittest.py 2018-08-27 22:19:52 UTC (rev 235404)
@@ -167,32 +167,3 @@
variable = self._sbFrame.FindVariable('hashSetOfInts')
summary = lldb_webkit.WTFHashSet_SummaryProvider(variable, {})
self.assertEqual(summary, "{ tableSize = 8, keyCount = 1 }")
-
- # MARK: WTFOptionSet_SummaryProvider test cases
-
- def serial_test_WTFOptionSet_SummaryProvider_empty(self):
- variable = self._sbFrame.FindVariable('exampleFlagsEmpty')
- summary = lldb_webkit.WTFOptionSet_SummaryProvider(variable, {})
- self.assertEqual(summary, "{ size = 0 }")
-
- def serial_test_WTFOptionSet_SummaryProvider_simple(self):
- variable = self._sbFrame.FindVariable('exampleFlagsSimple')
- summary = lldb_webkit.WTFOptionSet_SummaryProvider(variable, {})
- self.assertEqual(summary, "{ size = 3 }")
-
- # MARK: WTFOptionSetProvider test cases
-
- def serial_test_WTFOptionSetProvider_empty(self):
- variable = self._sbFrame.FindVariable('exampleFlagsEmpty')
- provider = lldb_webkit.WTFOptionSetProvider(variable, {})
- self.assertEqual(provider.get_child_at_index(0), None)
-
- def serial_test_WTFOptionSetProvider_simple(self):
- variable = self._sbFrame.FindVariable('exampleFlagsSimple')
- provider = lldb_webkit.WTFOptionSetProvider(variable, {})
- self.assertEqual(provider.get_child_at_index(0).GetName(), 'A')
- self.assertEqual(provider.get_child_at_index(0).GetValue(), '1')
- self.assertEqual(provider.get_child_at_index(1).GetName(), 'C')
- self.assertEqual(provider.get_child_at_index(1).GetValue(), '4')
- self.assertEqual(provider.get_child_at_index(2).GetName(), 'D')
- self.assertEqual(provider.get_child_at_index(2).GetValue(), '8')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
