Diff
Modified: trunk/Source/WebCore/ChangeLog (235420 => 235421)
--- trunk/Source/WebCore/ChangeLog 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/ChangeLog 2018-08-28 07:49:14 UTC (rev 235421)
@@ -1,3 +1,24 @@
+2018-08-28 Alejandro G. Castro <[email protected]>
+
+ Fix gcc compilation warnings after r235230
+ https://bugs.webkit.org/show_bug.cgi?id=188981
+
+ Reviewed by Eric Carlson.
+
+ Replace the pragma clang with pragma GCC, it is understood by
+ clang and gcc.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+ * platform/mediastream/RealtimeIncomingAudioSource.h:
+ * platform/mediastream/RealtimeIncomingVideoSource.h:
+ * platform/mediastream/RealtimeOutgoingAudioSource.h:
+ * platform/mediastream/RealtimeOutgoingVideoSource.h:
+ * platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
+ * platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+ * platform/mediastream/libwebrtc/LibWebRTCProvider.h:
+ * testing/MockLibWebRTCPeerConnection.h:
+
2018-08-27 Justin Fan <[email protected]>
WebGL 2 conformance: framebuffer-test
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h (235420 => 235421)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -29,12 +29,12 @@
#include "LibWebRTCMacros.h"
#include "RTCDataChannelHandler.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/datachannelinterface.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h (235420 => 235421)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -33,8 +33,8 @@
#include "RealtimeOutgoingVideoSource.h"
#include <Timer.h>
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/jsep.h>
#include <webrtc/api/peerconnectioninterface.h>
@@ -41,7 +41,7 @@
#include <webrtc/pc/peerconnectionfactory.h>
#include <webrtc/pc/rtcstatscollector.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/LoggerHelper.h>
#include <wtf/ThreadSafeRefCounted.h>
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -35,12 +35,12 @@
#include "LibWebRTCMacros.h"
#include "RealtimeMediaSource.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/mediastreaminterface.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/RetainPtr.h>
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -35,12 +35,12 @@
#include "LibWebRTCMacros.h"
#include "RealtimeMediaSource.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/mediastreaminterface.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/RetainPtr.h>
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -35,12 +35,12 @@
#include "MediaStreamTrackPrivate.h"
#include "Timer.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/mediastreaminterface.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/ThreadSafeRefCounted.h>
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -34,13 +34,13 @@
#include "MediaStreamTrackPrivate.h"
#include <Timer.h>
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/mediastreaminterface.h>
#include <webrtc/common_video/include/i420_buffer_pool.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/Optional.h>
#include <wtf/ThreadSafeRefCounted.h>
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -29,14 +29,14 @@
#include "LibWebRTCMacros.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/modules/audio_device/include/audio_device.h>
#include <webrtc/rtc_base/messagehandler.h>
#include <webrtc/rtc_base/thread.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
namespace WebCore {
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp 2018-08-28 07:49:14 UTC (rev 235421)
@@ -31,8 +31,8 @@
#include "Logging.h"
#include <dlfcn.h>
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/audio_codecs/builtin_audio_decoder_factory.h>
#include <webrtc/api/audio_codecs/builtin_audio_encoder_factory.h>
@@ -43,7 +43,7 @@
#include <webrtc/pc/peerconnectionfactory.h>
#include <webrtc/rtc_base/physicalsocketserver.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/Function.h>
#include <wtf/NeverDestroyed.h>
Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -35,8 +35,8 @@
#if USE(LIBWEBRTC)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/peerconnectioninterface.h>
#include <webrtc/api/video_codecs/video_encoder_factory.h>
@@ -43,7 +43,7 @@
#include <webrtc/api/video_codecs/video_decoder_factory.h>
#include <webrtc/rtc_base/scoped_ref_ptr.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
namespace rtc {
class NetworkManager;
Modified: trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.h (235420 => 235421)
--- trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -28,13 +28,13 @@
#include "LibWebRTCMacros.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include <webrtc/api/mediastreaminterface.h>
#include <webrtc/api/peerconnectioninterface.h>
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include <wtf/text/WTFString.h>
