Title: [235445] trunk/Tools
- Revision
- 235445
- Author
- [email protected]
- Date
- 2018-08-28 16:04:30 -0700 (Tue, 28 Aug 2018)
Log Message
lldb-webkit: KeyError thrown for OptionSet
https://bugs.webkit.org/show_bug.cgi?id=189062
Reviewed by Simon Fraser.
For some reason lldb(1) may not retrieve the enumerator names for an enum value
when it calls update() on the synthetic children provider. If this occurs then
bail out as we cannot compute what enumerators are in the set.
* lldb/lldb_webkit.py:
(WTFOptionSetProvider.update):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235444 => 235445)
--- trunk/Tools/ChangeLog 2018-08-28 22:25:38 UTC (rev 235444)
+++ trunk/Tools/ChangeLog 2018-08-28 23:04:30 UTC (rev 235445)
@@ -1,3 +1,17 @@
+2018-08-28 Daniel Bates <[email protected]>
+
+ lldb-webkit: KeyError thrown for OptionSet
+ https://bugs.webkit.org/show_bug.cgi?id=189062
+
+ Reviewed by Simon Fraser.
+
+ For some reason lldb(1) may not retrieve the enumerator names for an enum value
+ when it calls update() on the synthetic children provider. If this occurs then
+ bail out as we cannot compute what enumerators are in the set.
+
+ * lldb/lldb_webkit.py:
+ (WTFOptionSetProvider.update):
+
2018-08-28 Sihui Liu <[email protected]>
Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
Modified: trunk/Tools/lldb/lldb_webkit.py (235444 => 235445)
--- trunk/Tools/lldb/lldb_webkit.py 2018-08-28 22:25:38 UTC (rev 235444)
+++ trunk/Tools/lldb/lldb_webkit.py 2018-08-28 23:04:30 UTC (rev 235445)
@@ -616,6 +616,8 @@
template_argument_sbType = self.valobj.GetType().GetTemplateArgumentType(0)
enumerator_value_to_name_map = {sbTypeEnumMember.GetValueAsUnsigned(): sbTypeEnumMember.GetName() for sbTypeEnumMember in template_argument_sbType.get_enum_members_array()}
+ if not enumerator_value_to_name_map:
+ return
# Iterate from least significant bit to most significant bit.
elements = []
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
