Title: [235524] trunk/Source/WebCore
- Revision
- 235524
- Author
- [email protected]
- Date
- 2018-08-30 14:33:38 -0700 (Thu, 30 Aug 2018)
Log Message
REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
https://bugs.webkit.org/show_bug.cgi?id=189170
Patch by Olivia Barnett <[email protected]> on 2018-08-30
Reviewed by Tim Horton.
No new tests; fixing a failing existing test.
* page/Navigator.cpp:
(WebCore::Navigator::share):
Added null check for frame.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235523 => 235524)
--- trunk/Source/WebCore/ChangeLog 2018-08-30 20:54:35 UTC (rev 235523)
+++ trunk/Source/WebCore/ChangeLog 2018-08-30 21:33:38 UTC (rev 235524)
@@ -1,3 +1,16 @@
+2018-08-30 Olivia Barnett <[email protected]>
+
+ REGRESSION(r235489): fast/dom/navigator-detached-no-crash.html crashes under Navigator::share
+ https://bugs.webkit.org/show_bug.cgi?id=189170
+
+ Reviewed by Tim Horton.
+
+ No new tests; fixing a failing existing test.
+
+ * page/Navigator.cpp:
+ (WebCore::Navigator::share):
+ Added null check for frame.
+
2018-08-30 Truitt Savell <[email protected]>
Unreviewed, rolling out r235516.
Modified: trunk/Source/WebCore/page/Navigator.cpp (235523 => 235524)
--- trunk/Source/WebCore/page/Navigator.cpp 2018-08-30 20:54:35 UTC (rev 235523)
+++ trunk/Source/WebCore/page/Navigator.cpp 2018-08-30 21:33:38 UTC (rev 235524)
@@ -99,7 +99,7 @@
void Navigator::share(ScriptExecutionContext& context, ShareData data, Ref<DeferredPromise>&& promise)
{
- if (!m_frame->page()) {
+ if (!m_frame || !m_frame->page()) {
promise->reject(TypeError);
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
