Title: [235553] trunk/Source/WebKit
- Revision
- 235553
- Author
- [email protected]
- Date
- 2018-08-31 08:52:45 -0700 (Fri, 31 Aug 2018)
Log Message
REGRESSION(r235484) _WKPreferencesGetWebRTCLegacyAPIEnabled symbol not found when running Safari with external SDK build
https://bugs.webkit.org/show_bug.cgi?id=189188
Patch by Frederic Wang <[email protected]> on 2018-08-31
Reviewed by Youenn Fablet.
WebRTCLegacyAPI preference has been removed in r235484. However, the API is still used by
Safari when running external SDK builds. Hence we restore some dummy getter/setter for now.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebRTCLegacyAPIEnabled): no-op.
(WKPreferencesGetWebRTCLegacyAPIEnabled): Always return false.
* UIProcess/API/C/WKPreferencesRef.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _webRTCLegacyAPIEnabled]): Always return false.
(-[WKPreferences _setWebRTCLegacyAPIEnabled:]): no-op.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235552 => 235553)
--- trunk/Source/WebKit/ChangeLog 2018-08-31 15:51:53 UTC (rev 235552)
+++ trunk/Source/WebKit/ChangeLog 2018-08-31 15:52:45 UTC (rev 235553)
@@ -1,5 +1,24 @@
2018-08-31 Frederic Wang <[email protected]>
+ REGRESSION(r235484) _WKPreferencesGetWebRTCLegacyAPIEnabled symbol not found when running Safari with external SDK build
+ https://bugs.webkit.org/show_bug.cgi?id=189188
+
+ Reviewed by Youenn Fablet.
+
+ WebRTCLegacyAPI preference has been removed in r235484. However, the API is still used by
+ Safari when running external SDK builds. Hence we restore some dummy getter/setter for now.
+
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetWebRTCLegacyAPIEnabled): no-op.
+ (WKPreferencesGetWebRTCLegacyAPIEnabled): Always return false.
+ * UIProcess/API/C/WKPreferencesRef.h:
+ * UIProcess/API/Cocoa/WKPreferences.mm:
+ (-[WKPreferences _webRTCLegacyAPIEnabled]): Always return false.
+ (-[WKPreferences _setWebRTCLegacyAPIEnabled:]): no-op.
+ * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+
+2018-08-31 Frederic Wang <[email protected]>
+
Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
https://bugs.webkit.org/show_bug.cgi?id=182053
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (235552 => 235553)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-08-31 15:51:53 UTC (rev 235552)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2018-08-31 15:52:45 UTC (rev 235553)
@@ -1428,6 +1428,15 @@
return toImpl(preferencesRef)->peerConnectionEnabled();
}
+void WKPreferencesSetWebRTCLegacyAPIEnabled(WKPreferencesRef, bool)
+{
+}
+
+bool WKPreferencesGetWebRTCLegacyAPIEnabled(WKPreferencesRef)
+{
+ return false;
+}
+
void WKPreferencesSetWebRTCMDNSICECandidatesEnabled(WKPreferencesRef preferencesRef, bool enabled)
{
toImpl(preferencesRef)->setMDNSICECandidatesEnabled(enabled);
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h (235552 => 235553)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h 2018-08-31 15:51:53 UTC (rev 235552)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRef.h 2018-08-31 15:52:45 UTC (rev 235553)
@@ -268,6 +268,11 @@
WK_EXPORT void WKPreferencesSetPeerConnectionEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetPeerConnectionEnabled(WKPreferencesRef preferencesRef);
+// This is for backward compatibility with external SDK builds (https://webkit.org/b/189188).
+// FIXME: Remove these API functions.
+WK_EXPORT void WKPreferencesSetWebRTCLegacyAPIEnabled(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetWebRTCLegacyAPIEnabled(WKPreferencesRef preferencesRef);
+
// Defaults to false
WK_EXPORT void WKPreferencesSetWebRTCMDNSICECandidatesEnabled(WKPreferencesRef preferencesRef, bool enabled);
WK_EXPORT bool WKPreferencesGetWebRTCMDNSICECandidatesEnabled(WKPreferencesRef preferencesRef);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm (235552 => 235553)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-08-31 15:51:53 UTC (rev 235552)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm 2018-08-31 15:52:45 UTC (rev 235553)
@@ -669,6 +669,15 @@
_preferences->setICECandidateFilteringEnabled(enabled);
}
+- (BOOL)_webRTCLegacyAPIEnabled
+{
+ return NO;
+}
+
+- (void)_setWebRTCLegacyAPIEnabled:(BOOL)enabled
+{
+}
+
- (void)_setJavaScriptCanAccessClipboard:(BOOL)_javascript_CanAccessClipboard
{
_preferences->setJavaScriptCanAccessClipboard(_javascript_CanAccessClipboard);
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h (235552 => 235553)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-08-31 15:51:53 UTC (rev 235552)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2018-08-31 15:52:45 UTC (rev 235553)
@@ -118,6 +118,7 @@
@property (nonatomic, setter=_setMediaCaptureRequiresSecureConnection:) BOOL _mediaCaptureRequiresSecureConnection WK_API_AVAILABLE(macosx(10.13), ios(11.0));
@property (nonatomic, setter=_setEnumeratingAllNetworkInterfacesEnabled:) BOOL _enumeratingAllNetworkInterfacesEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));
@property (nonatomic, setter=_setICECandidateFilteringEnabled:) BOOL _iceCandidateFilteringEnabled WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));
+@property (nonatomic, setter=_setWebRTCLegacyAPIEnabled:) BOOL _webRTCLegacyAPIEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0));
@property (nonatomic, setter=_setInactiveMediaCaptureSteamRepromptIntervalInMinutes:) double _inactiveMediaCaptureSteamRepromptIntervalInMinutes WK_API_AVAILABLE(macosx(10.13.4), ios(11.3));
@property (nonatomic, setter=_setJavaScriptCanAccessClipboard:) BOOL _javaScriptCanAccessClipboard WK_API_AVAILABLE(macosx(10.13), ios(11.0));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
