Title: [235572] trunk/Tools
- Revision
- 235572
- Author
- [email protected]
- Date
- 2018-08-31 15:50:08 -0700 (Fri, 31 Aug 2018)
Log Message
Unreviewed, rolling out r235565.
https://bugs.webkit.org/show_bug.cgi?id=189212
Broke the WHLSL build (Requested by litherum on #webkit).
Reverted changeset:
"[WHLSL] Remove useless code in NameResolver"
https://bugs.webkit.org/show_bug.cgi?id=189176
https://trac.webkit.org/changeset/235565
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235571 => 235572)
--- trunk/Tools/ChangeLog 2018-08-31 22:23:22 UTC (rev 235571)
+++ trunk/Tools/ChangeLog 2018-08-31 22:50:08 UTC (rev 235572)
@@ -1,3 +1,16 @@
+2018-08-31 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r235565.
+ https://bugs.webkit.org/show_bug.cgi?id=189212
+
+ Broke the WHLSL build (Requested by litherum on #webkit).
+
+ Reverted changeset:
+
+ "[WHLSL] Remove useless code in NameResolver"
+ https://bugs.webkit.org/show_bug.cgi?id=189176
+ https://trac.webkit.org/changeset/235565
+
2018-08-31 Myles C. Maxfield <[email protected]>
[WHLSL] Remove useless code in NameResolver
Modified: trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js (235571 => 235572)
--- trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js 2018-08-31 22:23:22 UTC (rev 235571)
+++ trunk/Tools/WebGPUShadingLanguageRI/NameResolver.js 2018-08-31 22:50:08 UTC (rev 235572)
@@ -166,6 +166,16 @@
super.visitReturn(node);
}
+ _handlePropertyAccess(node)
+ {
+ node.possibleGetOverloads = this._nameContext.get(Func, node.getFuncName);
+ node.possibleSetOverloads = this._nameContext.get(Func, node.setFuncName);
+ node.possibleAndOverloads = this._nameContext.get(Func, node.andFuncName);
+
+ if (!node.possibleGetOverloads && !node.possibleAndOverloads)
+ throw new WTypeError(node.origin.originString, "Cannot find either " + node.getFuncName + " or " + node.andFuncName);
+ }
+
visitDotExpression(node)
{
// This could be a reference to an enum. Let's resolve that now.
@@ -180,9 +190,16 @@
}
}
+ this._handlePropertyAccess(node);
super.visitDotExpression(node);
}
+ visitIndexExpression(node)
+ {
+ this._handlePropertyAccess(node);
+ super.visitIndexExpression(node);
+ }
+
visitCallExpression(node)
{
let funcs = this._nameContext.get(Func, node.name);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
