Title: [235575] trunk/Source/WebCore
- Revision
- 235575
- Author
- [email protected]
- Date
- 2018-08-31 16:22:47 -0700 (Fri, 31 Aug 2018)
Log Message
Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header
https://bugs.webkit.org/show_bug.cgi?id=189203
Reviewed by Youenn Fablet.
If RealtimeOutgoingVideoSource.cpp is compiled alone (non-unified) or if it is the first file compiled in
a unified build, there is no pragma set to ignore unused parameter warnings in place.
* platform/mediastream/RealtimeOutgoingVideoSource.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235574 => 235575)
--- trunk/Source/WebCore/ChangeLog 2018-08-31 23:18:30 UTC (rev 235574)
+++ trunk/Source/WebCore/ChangeLog 2018-08-31 23:22:47 UTC (rev 235575)
@@ -1,3 +1,15 @@
+2018-08-31 Jer Noble <[email protected]>
+
+ Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header
+ https://bugs.webkit.org/show_bug.cgi?id=189203
+
+ Reviewed by Youenn Fablet.
+
+ If RealtimeOutgoingVideoSource.cpp is compiled alone (non-unified) or if it is the first file compiled in
+ a unified build, there is no pragma set to ignore unused parameter warnings in place.
+
+ * platform/mediastream/RealtimeOutgoingVideoSource.cpp:
+
2018-08-31 Wenson Hsieh <[email protected]>
[iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp (235574 => 235575)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp 2018-08-31 23:18:30 UTC (rev 235574)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.cpp 2018-08-31 23:22:47 UTC (rev 235575)
@@ -32,8 +32,15 @@
#if USE(LIBWEBRTC)
#include "Logging.h"
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
+
#include <webrtc/api/video/i420_buffer.h>
#include <webrtc/common_video/libyuv/include/webrtc_libyuv.h>
+
+#pragma GCC diagnostic pop
+
#include <wtf/MainThread.h>
namespace WebCore {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
