Title: [235583] trunk/Source/WebCore
- Revision
- 235583
- Author
- [email protected]
- Date
- 2018-09-01 13:16:01 -0700 (Sat, 01 Sep 2018)
Log Message
Add some more filter logging
https://bugs.webkit.org/show_bug.cgi?id=189221
Reviewed by Anders Carlsson.
Add logging in FilterEffect::apply() that shows all the filter rects, and logging
that brackets the application of a whole filter chain, for both SVG and CSS filters.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::apply):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235582 => 235583)
--- trunk/Source/WebCore/ChangeLog 2018-09-01 08:03:43 UTC (rev 235582)
+++ trunk/Source/WebCore/ChangeLog 2018-09-01 20:16:01 UTC (rev 235583)
@@ -1,3 +1,20 @@
+2018-09-01 Simon Fraser <[email protected]>
+
+ Add some more filter logging
+ https://bugs.webkit.org/show_bug.cgi?id=189221
+
+ Reviewed by Anders Carlsson.
+
+ Add logging in FilterEffect::apply() that shows all the filter rects, and logging
+ that brackets the application of a whole filter chain, for both SVG and CSS filters.
+
+ * platform/graphics/filters/FilterEffect.cpp:
+ (WebCore::FilterEffect::apply):
+ * rendering/FilterEffectRenderer.cpp:
+ (WebCore::FilterEffectRendererHelper::applyFilterEffect):
+ * rendering/svg/RenderSVGResourceFilter.cpp:
+ (WebCore::RenderSVGResourceFilter::postApplyResource):
+
2018-08-31 Youenn Fablet <[email protected]>
Move stats gathering out of LibWebRTCMediaEndpoint
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp (235582 => 235583)
--- trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp 2018-09-01 08:03:43 UTC (rev 235582)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp 2018-09-01 20:16:01 UTC (rev 235583)
@@ -135,6 +135,8 @@
determineAbsolutePaintRect();
setResultColorSpace(m_operatingColorSpace);
+ LOG_WITH_STREAM(Filters, stream << "FilterEffect " << filterName() << " " << this << " apply():\n filterPrimitiveSubregion " << m_filterPrimitiveSubregion << "\n effectBoundaries " << m_effectBoundaries << "\n absoluteUnclippedSubregion " << m_absoluteUnclippedSubregion << "\n absolutePaintRect " << m_absolutePaintRect << "\n maxEffectRect " << m_maxEffectRect << "\n filter scale " << m_filter.filterScale() << "\n filter resolution " << m_filter.filterResolution());
+
if (m_absolutePaintRect.isEmpty() || ImageBuffer::sizeNeedsClamping(m_absolutePaintRect.size()))
return;
Modified: trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp (235582 => 235583)
--- trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2018-09-01 08:03:43 UTC (rev 235582)
+++ trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp 2018-09-01 20:16:01 UTC (rev 235583)
@@ -35,6 +35,7 @@
#include "FEDropShadow.h"
#include "FEGaussianBlur.h"
#include "FEMerge.h"
+#include "Logging.h"
#include "RenderLayer.h"
#include "SVGElement.h"
#include "SVGFilterBuilder.h"
@@ -458,6 +459,8 @@
ASSERT(m_renderLayer->filterRenderer());
ASSERT(m_renderLayer->filterRenderer()->inputContext());
+ LOG_WITH_STREAM(Filters, stream << "\nFilterEffectRendererHelper " << this << " applyFilterEffect");
+
auto& filter = *m_renderLayer->filterRenderer();
filter.inputContext()->restore();
@@ -471,6 +474,8 @@
destinationContext.drawImageBuffer(*outputBuffer, snapRectToDevicePixels(destRect, m_renderLayer->renderer().document().deviceScaleFactor()));
filter.clearIntermediateResults();
+
+ LOG_WITH_STREAM(Filters, stream << "FilterEffectRendererHelper " << this << " applyFilterEffect done\n");
}
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp (235582 => 235583)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2018-09-01 08:03:43 UTC (rev 235582)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp 2018-09-01 20:16:01 UTC (rev 235583)
@@ -297,6 +297,8 @@
}
}
filterData.sourceGraphicBuffer.reset();
+
+ LOG_WITH_STREAM(Filters, stream << "RenderSVGResourceFilter " << this << " postApplyResource done\n");
}
FloatRect RenderSVGResourceFilter::resourceBoundingBox(const RenderObject& object)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
