Title: [235652] trunk/Source/WebCore
- Revision
- 235652
- Author
- [email protected]
- Date
- 2018-09-04 18:22:55 -0700 (Tue, 04 Sep 2018)
Log Message
Remove PseudoElementUserAgentCustom.
https://bugs.webkit.org/show_bug.cgi?id=189089
Reviewed by Ryosuke Niwa.
Tests at https://github.com/web-platform-tests/wpt/pull/12743.
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::parsePseudoElementType):
* css/CSSSelector.h:
(WebCore::CSSSelector::isCustomPseudoElement const):
* css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
* css/parser/CSSParserSelector.h:
(WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235651 => 235652)
--- trunk/Source/WebCore/ChangeLog 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/ChangeLog 2018-09-05 01:22:55 UTC (rev 235652)
@@ -1,3 +1,22 @@
+2018-08-29 Emilio Cobos Álvarez <[email protected]>
+
+ Remove PseudoElementUserAgentCustom.
+ https://bugs.webkit.org/show_bug.cgi?id=189089
+
+ Reviewed by Ryosuke Niwa.
+
+ Tests at https://github.com/web-platform-tests/wpt/pull/12743.
+
+ * css/CSSSelector.cpp:
+ (WebCore::CSSSelector::pseudoId):
+ (WebCore::CSSSelector::parsePseudoElementType):
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::isCustomPseudoElement const):
+ * css/RuleSet.cpp:
+ (WebCore::RuleSet::addRule):
+ * css/parser/CSSParserSelector.h:
+ (WebCore::CSSParserSelector::needsImplicitShadowCombinatorForMatching const):
+
2018-09-04 Dean Jackson <[email protected]>
Post review Weinig fix-ups
Modified: trunk/Source/WebCore/css/CSSSelector.cpp (235651 => 235652)
--- trunk/Source/WebCore/css/CSSSelector.cpp 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/CSSSelector.cpp 2018-09-05 01:22:55 UTC (rev 235652)
@@ -299,7 +299,6 @@
#endif
case PseudoElementSlotted:
case PseudoElementUnknown:
- case PseudoElementUserAgentCustom:
case PseudoElementWebKitCustom:
case PseudoElementWebKitCustomLegacyPrefixed:
return PseudoId::None;
@@ -318,9 +317,6 @@
if (type == PseudoElementUnknown) {
if (name.startsWith("-webkit-"))
type = PseudoElementWebKitCustom;
-
- if (name.startsWith("x-"))
- type = PseudoElementUserAgentCustom;
}
return type;
}
Modified: trunk/Source/WebCore/css/CSSSelector.h (235651 => 235652)
--- trunk/Source/WebCore/css/CSSSelector.h 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/CSSSelector.h 2018-09-05 01:22:55 UTC (rev 235652)
@@ -183,7 +183,6 @@
PseudoElementScrollbarTrackPiece,
PseudoElementSelection,
PseudoElementSlotted,
- PseudoElementUserAgentCustom,
PseudoElementWebKitCustom,
// WebKitCustom that appeared in an old prefixed form
@@ -411,8 +410,7 @@
inline bool CSSSelector::isCustomPseudoElement() const
{
return match() == PseudoElement
- && (pseudoElementType() == PseudoElementUserAgentCustom
- || pseudoElementType() == PseudoElementWebKitCustom
+ && (pseudoElementType() == PseudoElementWebKitCustom
|| pseudoElementType() == PseudoElementWebKitCustomLegacyPrefixed);
}
Modified: trunk/Source/WebCore/css/RuleSet.cpp (235651 => 235652)
--- trunk/Source/WebCore/css/RuleSet.cpp 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/RuleSet.cpp 2018-09-05 01:22:55 UTC (rev 235652)
@@ -242,7 +242,6 @@
break;
case CSSSelector::PseudoElement:
switch (selector->pseudoElementType()) {
- case CSSSelector::PseudoElementUserAgentCustom:
case CSSSelector::PseudoElementWebKitCustom:
case CSSSelector::PseudoElementWebKitCustomLegacyPrefixed:
customPseudoElementSelector = selector;
Modified: trunk/Source/WebCore/css/parser/CSSParserSelector.h (235651 => 235652)
--- trunk/Source/WebCore/css/parser/CSSParserSelector.h 2018-09-05 00:50:33 UTC (rev 235651)
+++ trunk/Source/WebCore/css/parser/CSSParserSelector.h 2018-09-05 01:22:55 UTC (rev 235652)
@@ -117,7 +117,6 @@
{
return match() == CSSSelector::PseudoElement
&& (pseudoElementType() == CSSSelector::PseudoElementWebKitCustom
- || pseudoElementType() == CSSSelector::PseudoElementUserAgentCustom
#if ENABLE(VIDEO_TRACK)
|| pseudoElementType() == CSSSelector::PseudoElementCue
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
