Title: [235717] trunk/Websites/webkit.org
- Revision
- 235717
- Author
- [email protected]
- Date
- 2018-09-05 19:54:58 -0700 (Wed, 05 Sep 2018)
Log Message
Update code style guidelines for using namespace inside a namespace definition
https://bugs.webkit.org/show_bug.cgi?id=189298
Reviewed by Ryosuke Niwa.
"using namespace" statements should be inside namespace definitions for
unified source builds.
* code-style.md(#using-position):
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (235716 => 235717)
--- trunk/Websites/webkit.org/ChangeLog 2018-09-06 01:42:10 UTC (rev 235716)
+++ trunk/Websites/webkit.org/ChangeLog 2018-09-06 02:54:58 UTC (rev 235717)
@@ -1,3 +1,15 @@
+2018-09-05 Fujii Hironori <[email protected]>
+
+ Update code style guidelines for using namespace inside a namespace definition
+ https://bugs.webkit.org/show_bug.cgi?id=189298
+
+ Reviewed by Ryosuke Niwa.
+
+ "using namespace" statements should be inside namespace definitions for
+ unified source builds.
+
+ * code-style.md(#using-position):
+
2018-08-31 Dean Jackson <[email protected]>
Add support for USDZ to webkit.org for a sample file
Modified: trunk/Websites/webkit.org/code-style.md (235716 => 235717)
--- trunk/Websites/webkit.org/code-style.md 2018-09-06 01:42:10 UTC (rev 235716)
+++ trunk/Websites/webkit.org/code-style.md 2018-09-06 02:54:58 UTC (rev 235717)
@@ -1126,7 +1126,7 @@
} // namespace WebCore
```
-[](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements.
+[](#using-position) In implementation files, put all "using namespace" statements inside namespace definitions.
###### Right:
@@ -1133,10 +1133,10 @@
```cpp
// HTMLSelectElement.cpp
+namespace WebCore {
+
using namespace other;
-namespace WebCore {
-
} // namespace WebCore
```
@@ -1145,10 +1145,10 @@
```cpp
// HTMLSelectElement.cpp
+using namespace other;
+
namespace WebCore {
-using namespace other;
-
} // namespace WebCore
```
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
