Title: [235825] trunk/Source/WebCore
- Revision
- 235825
- Author
- [email protected]
- Date
- 2018-09-07 17:41:14 -0700 (Fri, 07 Sep 2018)
Log Message
[Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
https://bugs.webkit.org/show_bug.cgi?id=189402
Reviewed by Alex Christensen.
Clang reports compilation errors like following:
> StructuredExceptionHandlerSuppressor.cpp(38,10): error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
> case EXCEPTION_DATATYPE_MISALIGNMENT:
> ^
No new tests (no behavioral change).
* platform/win/StructuredExceptionHandlerSuppressor.cpp:
(exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235824 => 235825)
--- trunk/Source/WebCore/ChangeLog 2018-09-08 00:37:16 UTC (rev 235824)
+++ trunk/Source/WebCore/ChangeLog 2018-09-08 00:41:14 UTC (rev 235825)
@@ -1,3 +1,21 @@
+2018-09-07 Fujii Hironori <[email protected]>
+
+ [Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
+ https://bugs.webkit.org/show_bug.cgi?id=189402
+
+ Reviewed by Alex Christensen.
+
+ Clang reports compilation errors like following:
+
+ > StructuredExceptionHandlerSuppressor.cpp(38,10): error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
+ > case EXCEPTION_DATATYPE_MISALIGNMENT:
+ > ^
+
+ No new tests (no behavioral change).
+
+ * platform/win/StructuredExceptionHandlerSuppressor.cpp:
+ (exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.
+
2018-09-07 Basuke Suzuki <[email protected]>
[Curl] Stop sending request with credential if no authorization requested.
Modified: trunk/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp (235824 => 235825)
--- trunk/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp 2018-09-08 00:37:16 UTC (rev 235824)
+++ trunk/Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp 2018-09-08 00:41:14 UTC (rev 235825)
@@ -31,7 +31,7 @@
extern "C" int __stdcall exceptionHandlerThunk(); // Defined in makesafeseh.asm
#endif
-static bool exceptionShouldTerminateProgram(int code)
+static bool exceptionShouldTerminateProgram(DWORD code)
{
switch (code) {
#ifndef NDEBUG
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
