Title: [235836] trunk/Tools
- Revision
- 235836
- Author
- [email protected]
- Date
- 2018-09-08 22:02:34 -0700 (Sat, 08 Sep 2018)
Log Message
accessibility/notification-listeners.html abandons a document
https://bugs.webkit.org/show_bug.cgi?id=188724
Reviewed by Darin Adler.
AccessibilityControllerMac leaked m_globalNotificationHandler, which leaks a JSValueProtect'd function,
which leaks a Document. Fix by using adoptNS().
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::addNotificationListener):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (235835 => 235836)
--- trunk/Tools/ChangeLog 2018-09-09 04:24:33 UTC (rev 235835)
+++ trunk/Tools/ChangeLog 2018-09-09 05:02:34 UTC (rev 235836)
@@ -1,3 +1,16 @@
+2018-09-08 Simon Fraser <[email protected]>
+
+ accessibility/notification-listeners.html abandons a document
+ https://bugs.webkit.org/show_bug.cgi?id=188724
+
+ Reviewed by Darin Adler.
+
+ AccessibilityControllerMac leaked m_globalNotificationHandler, which leaks a JSValueProtect'd function,
+ which leaks a Document. Fix by using adoptNS().
+
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
+ (WTR::AccessibilityController::addNotificationListener):
+
2018-09-08 Wenson Hsieh <[email protected]>
[Cocoa] Use more bridging casts in TestWebKitAPI
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm (235835 => 235836)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm 2018-09-09 04:24:33 UTC (rev 235835)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm 2018-09-09 05:02:34 UTC (rev 235836)
@@ -51,7 +51,8 @@
if (m_globalNotificationHandler)
return false;
- m_globalNotificationHandler = [[AccessibilityNotificationHandler alloc] init];
+
+ m_globalNotificationHandler = adoptNS([[AccessibilityNotificationHandler alloc] init]);
[m_globalNotificationHandler.get() setCallback:functionCallback];
[m_globalNotificationHandler.get() startObserving];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
