Title: [235857] trunk/Source/WebCore
- Revision
- 235857
- Author
- [email protected]
- Date
- 2018-09-10 13:39:57 -0700 (Mon, 10 Sep 2018)
Log Message
[macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused
https://bugs.webkit.org/show_bug.cgi?id=189480
Reviewed by Anders Carlsson.
No new tests, because this doesn’t change behavior.
* editing/Editor.h: Removed the MailBlockquoteHandling argument from
readSelectionFromPasteboard.
* editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Don’t pass mailBlockquoteHandling to
pasteWithPasteboard. It was always set to RespectBlockquote, which is the latter’s
default.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235856 => 235857)
--- trunk/Source/WebCore/ChangeLog 2018-09-10 20:08:00 UTC (rev 235856)
+++ trunk/Source/WebCore/ChangeLog 2018-09-10 20:39:57 UTC (rev 235857)
@@ -1,3 +1,19 @@
+2018-09-10 Dan Bernstein <[email protected]>
+
+ [macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused
+ https://bugs.webkit.org/show_bug.cgi?id=189480
+
+ Reviewed by Anders Carlsson.
+
+ No new tests, because this doesn’t change behavior.
+
+ * editing/Editor.h: Removed the MailBlockquoteHandling argument from
+ readSelectionFromPasteboard.
+ * editing/mac/EditorMac.mm:
+ (WebCore::Editor::readSelectionFromPasteboard): Don’t pass mailBlockquoteHandling to
+ pasteWithPasteboard. It was always set to RespectBlockquote, which is the latter’s
+ default.
+
2018-09-10 Andy Estes <[email protected]>
[Payment Request] Use JSValueInWrappedObject for PaymentResponse's details attribute
Modified: trunk/Source/WebCore/editing/Editor.h (235856 => 235857)
--- trunk/Source/WebCore/editing/Editor.h 2018-09-10 20:08:00 UTC (rev 235856)
+++ trunk/Source/WebCore/editing/Editor.h 2018-09-10 20:39:57 UTC (rev 235857)
@@ -471,7 +471,7 @@
#if !PLATFORM(IOS)
bool canCopyExcludingStandaloneImages();
void takeFindStringFromSelection();
- WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling = MailBlockquoteHandling::RespectBlockquote);
+ WEBCORE_EXPORT void readSelectionFromPasteboard(const String& pasteboardName);
WEBCORE_EXPORT void replaceNodeFromPasteboard(Node*, const String& pasteboardName);
WEBCORE_EXPORT RefPtr<SharedBuffer> dataSelectionForPasteboard(const String& pasteboardName);
#endif // !PLATFORM(IOS)
Modified: trunk/Source/WebCore/editing/mac/EditorMac.mm (235856 => 235857)
--- trunk/Source/WebCore/editing/mac/EditorMac.mm 2018-09-10 20:08:00 UTC (rev 235856)
+++ trunk/Source/WebCore/editing/mac/EditorMac.mm 2018-09-10 20:39:57 UTC (rev 235857)
@@ -118,11 +118,11 @@
#pragma clang diagnostic pop
}
-void Editor::readSelectionFromPasteboard(const String& pasteboardName, MailBlockquoteHandling mailBlockquoteHandling)
+void Editor::readSelectionFromPasteboard(const String& pasteboardName)
{
Pasteboard pasteboard(pasteboardName);
if (m_frame.selection().selection().isContentRichlyEditable())
- pasteWithPasteboard(&pasteboard, true, mailBlockquoteHandling);
+ pasteWithPasteboard(&pasteboard, true);
else
pasteAsPlainTextWithPasteboard(pasteboard);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
