Diff
Modified: trunk/LayoutTests/ChangeLog (235865 => 235866)
--- trunk/LayoutTests/ChangeLog 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/ChangeLog 2018-09-10 22:16:35 UTC (rev 235866)
@@ -1,3 +1,16 @@
+2018-09-10 James Savage <[email protected]>
+
+ Expose -apple-system-container-border color to internal web views.
+ https://bugs.webkit.org/show_bug.cgi?id=189178.
+
+ Reviewed by Timothy Hatcher.
+
+ * fast/css/apple-system-control-colors-expected.txt:
+ * fast/css/apple-system-control-colors.html:
+ * platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
+ * platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt:
+ * platform/mac/fast/css/apple-system-control-colors-expected.txt:
+
2018-09-07 Ryosuke Niwa <[email protected]>
mouseenter and mouseleave events don't get dispatched even when there is a capturing event listener for a slot ancestor
Modified: trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt (235865 => 235866)
--- trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/fast/css/apple-system-control-colors-expected.txt 2018-09-10 22:16:35 UTC (rev 235866)
@@ -19,4 +19,5 @@
-apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
-apple-system-grid : rgb(204, 204, 204)
-apple-system-separator : rgb(204, 204, 204)
+-apple-system-container-border : rgb(197, 197, 197)
current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)
Modified: trunk/LayoutTests/fast/css/apple-system-control-colors.html (235865 => 235866)
--- trunk/LayoutTests/fast/css/apple-system-control-colors.html 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/fast/css/apple-system-control-colors.html 2018-09-10 22:16:35 UTC (rev 235866)
@@ -42,4 +42,5 @@
<div><span class="swatch" style="background-color: -apple-system-quaternary-label"></span>-apple-system-quaternary-label</div>
<div><span class="swatch" style="background-color: -apple-system-grid"></span>-apple-system-grid</div>
<div><span class="swatch" style="background-color: -apple-system-separator"></span>-apple-system-separator</div>
+<div><span class="swatch" style="background-color: -apple-system-container-border"></span>-apple-system-container-border</div>
<div style="color: -apple-system-label"><span class="swatch" style="background-color: currentcolor;"></span>current-color with inherited -apple-system-label</div>
Modified: trunk/LayoutTests/platform/mac/fast/css/apple-system-control-colors-expected.txt (235865 => 235866)
--- trunk/LayoutTests/platform/mac/fast/css/apple-system-control-colors-expected.txt 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/platform/mac/fast/css/apple-system-control-colors-expected.txt 2018-09-10 22:16:35 UTC (rev 235866)
@@ -19,4 +19,5 @@
-apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
-apple-system-grid : rgb(204, 204, 204)
-apple-system-separator : rgba(0, 0, 0, 0.0980392)
+-apple-system-container-border : rgba(0, 0, 0, 0.247059)
current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.847059)
Modified: trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt (235865 => 235866)
--- trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt 2018-09-10 22:16:35 UTC (rev 235866)
@@ -19,4 +19,5 @@
-apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
-apple-system-grid : rgb(204, 204, 204)
-apple-system-separator : rgb(204, 204, 204)
+-apple-system-container-border : rgb(197, 197, 197)
current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)
Modified: trunk/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt (235865 => 235866)
--- trunk/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/LayoutTests/platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt 2018-09-10 22:16:35 UTC (rev 235866)
@@ -19,4 +19,5 @@
-apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
-apple-system-grid : rgb(204, 204, 204)
-apple-system-separator : rgb(204, 204, 204)
+-apple-system-container-border : rgb(197, 197, 197)
current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)
Modified: trunk/Source/WebCore/ChangeLog (235865 => 235866)
--- trunk/Source/WebCore/ChangeLog 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/Source/WebCore/ChangeLog 2018-09-10 22:16:35 UTC (rev 235866)
@@ -1,3 +1,17 @@
+2018-09-10 James Savage <[email protected]>
+
+ Expose -apple-system-container-border color to internal web views.
+ https://bugs.webkit.org/show_bug.cgi?id=189178.
+
+ Reviewed by Timothy Hatcher.
+
+ Tests: LayoutTests/fast/css/apple-system-colors.html
+
+ * css/CSSValueKeywords.in: Add new semantic color name.
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemColor const): Use system color on supported
+ systems, and fall back to approximation for older systems.
+
2018-09-07 Ryosuke Niwa <[email protected]>
mouseenter and mouseleave events don't get dispatched even when there is a capturing event listener for a slot ancestor
Modified: trunk/Source/WebCore/PAL/ChangeLog (235865 => 235866)
--- trunk/Source/WebCore/PAL/ChangeLog 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/Source/WebCore/PAL/ChangeLog 2018-09-10 22:16:35 UTC (rev 235866)
@@ -1,3 +1,12 @@
+2018-09-10 James Savage <[email protected]>
+
+ Expose -apple-system-container-border color to internal web views.
+ https://bugs.webkit.org/show_bug.cgi?id=189178.
+
+ Reviewed by Timothy Hatcher.
+
+ * pal/spi/cocoa/NSColorSPI.h: Declare SPI.
+
2018-09-06 Megan Gardner <[email protected]>
Add Support for Conic Gradients
Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h (235865 => 235866)
--- trunk/Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/NSColorSPI.h 2018-09-10 22:16:35 UTC (rev 235866)
@@ -48,6 +48,7 @@
+ (NSColor *)linkColor;
+ (NSColor *)findHighlightColor;
+ (NSColor *)placeholderTextColor;
++ (NSColor *)containerBorderColor;
@end
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (235865 => 235866)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2018-09-10 22:16:35 UTC (rev 235866)
@@ -244,6 +244,7 @@
-apple-system-quaternary-label
-apple-system-grid
-apple-system-separator
+-apple-system-container-border
#endif
-apple-wireless-playback-target-active
-apple-system-blue
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (235865 => 235866)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-09-10 21:54:14 UTC (rev 235865)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-09-10 22:16:35 UTC (rev 235866)
@@ -768,6 +768,13 @@
// Handled below.
return nullptr;
#endif
+ case CSSValueAppleSystemContainerBorder:
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+ return @selector(containerBorderColor);
+#else
+ // Handled below.
+ return nullptr;
+#endif
case CSSValueAppleSystemLabel:
return @selector(labelColor);
case CSSValueAppleSystemSecondaryLabel:
@@ -860,6 +867,9 @@
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101300
case CSSValueAppleSystemFindHighlightBackground:
return platformActiveTextSearchHighlightColor(options);
+
+ case CSSValueAppleSystemContainerBorder:
+ return 0xFFC5C5C5;
#endif
case CSSValueAppleSystemEvenAlternatingContentBackground: {
