Title: [235906] trunk/Source/WebKit
Revision
235906
Author
[email protected]
Date
2018-09-11 11:38:28 -0700 (Tue, 11 Sep 2018)

Log Message

Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp
https://bugs.webkit.org/show_bug.cgi?id=189506

Patch by Pablo Saavedra <[email protected]> on 2018-09-11
Reviewed by Tim Horton.

m_pipStandbyElement is only defined in
WebKit/WebProcess/FullScreen/WebFullScreenManager.h
only when ENABLE(VIDEO) (see
https://bugs.webkit.org/show_bug.cgi?id=181338)

* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::setPIPStandbyElement):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (235905 => 235906)


--- trunk/Source/WebKit/ChangeLog	2018-09-11 18:25:56 UTC (rev 235905)
+++ trunk/Source/WebKit/ChangeLog	2018-09-11 18:38:28 UTC (rev 235906)
@@ -1,3 +1,18 @@
+2018-09-11  Pablo Saavedra  <[email protected]>
+
+        Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=189506
+
+        Reviewed by Tim Horton.
+
+        m_pipStandbyElement is only defined in
+        WebKit/WebProcess/FullScreen/WebFullScreenManager.h
+        only when ENABLE(VIDEO) (see
+        https://bugs.webkit.org/show_bug.cgi?id=181338)
+
+        * WebProcess/FullScreen/WebFullScreenManager.cpp:
+        (WebKit::WebFullScreenManager::setPIPStandbyElement):
+
 2018-09-11  Michael Catanzaro  <[email protected]>
 
         WebPageProxy should hold a WeakPtr to its PageClient

Modified: trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp (235905 => 235906)


--- trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp	2018-09-11 18:25:56 UTC (rev 235905)
+++ trunk/Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp	2018-09-11 18:38:28 UTC (rev 235906)
@@ -99,6 +99,7 @@
 
 void WebFullScreenManager::setPIPStandbyElement(WebCore::HTMLVideoElement* pipStandbyElement)
 {
+#if ENABLE(VIDEO)
     if (pipStandbyElement == m_pipStandbyElement)
         return;
 
@@ -109,6 +110,7 @@
 
     if (m_pipStandbyElement)
         m_pipStandbyElement->setVideoFullscreenStandby(true);
+#endif
 }
 
 void WebFullScreenManager::didReceiveMessage(IPC::Connection& connection, IPC::Decoder& decoder)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to