Title: [235922] trunk
- Revision
- 235922
- Author
- [email protected]
- Date
- 2018-09-11 16:41:49 -0700 (Tue, 11 Sep 2018)
Log Message
Follow up to:
Expose -apple-system-container-border color to internal web views.
https://bugs.webkit.org/show_bug.cgi?id=189178.
Patch by James Savage <[email protected]> on 2018-09-11
Reviewed by Timothy Hatcher.
Source/WebCore:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor const): Add a separate #if block for
Mojave. When I used CSSValueAppleSystemFindHighlightBackground as a template
for this change, I had to write out the condition in the first change, but
mistakenly thought I could reuse the block here. Turns out the versions were
different, and I could not.
LayoutTests:
* platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
Reset test expectations to go along with fix.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (235921 => 235922)
--- trunk/LayoutTests/ChangeLog 2018-09-11 23:23:38 UTC (rev 235921)
+++ trunk/LayoutTests/ChangeLog 2018-09-11 23:41:49 UTC (rev 235922)
@@ -1,3 +1,14 @@
+2018-09-11 James Savage <[email protected]>
+
+ Follow up to:
+ Expose -apple-system-container-border color to internal web views.
+ https://bugs.webkit.org/show_bug.cgi?id=189178.
+
+ Reviewed by Timothy Hatcher.
+
+ * platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
+ Reset test expectations to go along with fix.
+
2018-09-07 Dean Jackson <[email protected]>
Add and expose Internal features from WebKit
Modified: trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt (235921 => 235922)
--- trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt 2018-09-11 23:23:38 UTC (rev 235921)
+++ trunk/LayoutTests/platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt 2018-09-11 23:41:49 UTC (rev 235922)
@@ -19,5 +19,5 @@
-apple-system-quaternary-label : rgba(0, 0, 0, 0.0980392)
-apple-system-grid : rgb(204, 204, 204)
-apple-system-separator : rgb(204, 204, 204)
--apple-system-container-border : rgba(0, 0, 0, 0)
+-apple-system-container-border : rgb(197, 197, 197)
current-color with inherited -apple-system-label : rgba(0, 0, 0, 0.85098)
Modified: trunk/Source/WebCore/ChangeLog (235921 => 235922)
--- trunk/Source/WebCore/ChangeLog 2018-09-11 23:23:38 UTC (rev 235921)
+++ trunk/Source/WebCore/ChangeLog 2018-09-11 23:41:49 UTC (rev 235922)
@@ -1,3 +1,18 @@
+2018-09-11 James Savage <[email protected]>
+
+ Follow up to:
+ Expose -apple-system-container-border color to internal web views.
+ https://bugs.webkit.org/show_bug.cgi?id=189178.
+
+ Reviewed by Timothy Hatcher.
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemColor const): Add a separate #if block for
+ Mojave. When I used CSSValueAppleSystemFindHighlightBackground as a template
+ for this change, I had to write out the condition in the first change, but
+ mistakenly thought I could reuse the block here. Turns out the versions were
+ different, and I could not.
+
2018-09-11 Youenn Fablet <[email protected]>
Remove MediaDevices NoInterfaceObject
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (235921 => 235922)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-09-11 23:23:38 UTC (rev 235921)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2018-09-11 23:41:49 UTC (rev 235922)
@@ -867,7 +867,9 @@
#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101300
case CSSValueAppleSystemFindHighlightBackground:
return platformActiveTextSearchHighlightColor(options);
+#endif
+#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
case CSSValueAppleSystemContainerBorder:
return 0xFFC5C5C5;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
