Title: [235977] trunk/Source/WebCore
- Revision
- 235977
- Author
- [email protected]
- Date
- 2018-09-13 10:16:05 -0700 (Thu, 13 Sep 2018)
Log Message
Remove a MSVC workaround in InspectorStyle::styleWithProperties
https://bugs.webkit.org/show_bug.cgi?id=189577
Reviewed by Alex Christensen.
No new tests (No behavior change).
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties const): Use 'auto' for the type of 'status'.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235976 => 235977)
--- trunk/Source/WebCore/ChangeLog 2018-09-13 17:02:24 UTC (rev 235976)
+++ trunk/Source/WebCore/ChangeLog 2018-09-13 17:16:05 UTC (rev 235977)
@@ -1,3 +1,15 @@
+2018-09-13 Fujii Hironori <[email protected]>
+
+ Remove a MSVC workaround in InspectorStyle::styleWithProperties
+ https://bugs.webkit.org/show_bug.cgi?id=189577
+
+ Reviewed by Alex Christensen.
+
+ No new tests (No behavior change).
+
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::InspectorStyle::styleWithProperties const): Use 'auto' for the type of 'status'.
+
2018-09-13 Alex Christensen <[email protected]>
Use a Variant instead of a union in CSSSelector
Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (235976 => 235977)
--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2018-09-13 17:02:24 UTC (rev 235976)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2018-09-13 17:16:05 UTC (rev 235977)
@@ -634,13 +634,7 @@
const CSSPropertySourceData& propertyEntry = it->sourceData;
const String& name = propertyEntry.name;
- // Visual Studio disagrees with other compilers as to whether 'class' is needed here.
-#if COMPILER(MSVC)
- enum class Protocol::CSS::CSSPropertyStatus status;
-#else
- enum Inspector::Protocol::CSS::CSSPropertyStatus status;
-#endif
- status = it->disabled ? Inspector::Protocol::CSS::CSSPropertyStatus::Disabled : Inspector::Protocol::CSS::CSSPropertyStatus::Active;
+ auto status = it->disabled ? Inspector::Protocol::CSS::CSSPropertyStatus::Disabled : Inspector::Protocol::CSS::CSSPropertyStatus::Active;
RefPtr<Inspector::Protocol::CSS::CSSProperty> property = Inspector::Protocol::CSS::CSSProperty::create()
.setName(name.convertToASCIILowercase())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
