Title: [235982] trunk/Source/WebCore
- Revision
- 235982
- Author
- ms2...@igalia.com
- Date
- 2018-09-13 12:08:47 -0700 (Thu, 13 Sep 2018)
Log Message
[GLib] Fix format string in KeyedEncoderGlib::beginObject().
https://bugs.webkit.org/show_bug.cgi?id=189585
Reviewed by Michael Catanzaro.
This appears to fix the following assertion locally:
GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed
Covered by existing tests.
* platform/glib/KeyedEncoderGlib.cpp:
(WebCore::KeyedEncoderGlib::beginObject):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235981 => 235982)
--- trunk/Source/WebCore/ChangeLog 2018-09-13 18:07:22 UTC (rev 235981)
+++ trunk/Source/WebCore/ChangeLog 2018-09-13 19:08:47 UTC (rev 235982)
@@ -1,3 +1,19 @@
+2018-09-13 Ms2ger <ms2...@igalia.com>
+
+ [GLib] Fix format string in KeyedEncoderGlib::beginObject().
+ https://bugs.webkit.org/show_bug.cgi?id=189585
+
+ Reviewed by Michael Catanzaro.
+
+ This appears to fix the following assertion locally:
+
+ GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed
+
+ Covered by existing tests.
+
+ * platform/glib/KeyedEncoderGlib.cpp:
+ (WebCore::KeyedEncoderGlib::beginObject):
+
2018-09-13 Ryan Haddad <ryanhad...@apple.com>
Unreviewed, rolling out r235953.
Modified: trunk/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp (235981 => 235982)
--- trunk/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp 2018-09-13 18:07:22 UTC (rev 235981)
+++ trunk/Source/WebCore/platform/glib/KeyedEncoderGlib.cpp 2018-09-13 19:08:47 UTC (rev 235982)
@@ -98,7 +98,7 @@
void KeyedEncoderGlib::beginObject(const String& key)
{
- GRefPtr<GVariantBuilder> builder = adoptGRef(g_variant_builder_new(G_VARIANT_TYPE("aa{sv}")));
+ GRefPtr<GVariantBuilder> builder = adoptGRef(g_variant_builder_new(G_VARIANT_TYPE("a{sv}")));
m_objectStack.append(std::make_pair(key, builder));
m_variantBuilderStack.append(builder.get());
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
