Title: [235984] trunk/Source/WebKit
- Revision
- 235984
- Author
- [email protected]
- Date
- 2018-09-13 12:18:13 -0700 (Thu, 13 Sep 2018)
Log Message
Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
https://bugs.webkit.org/show_bug.cgi?id=189587
Reviewed by Geoffrey Garen.
Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
as this is causing crashes on the bots.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCompletePageTransition):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235983 => 235984)
--- trunk/Source/WebKit/ChangeLog 2018-09-13 19:11:27 UTC (rev 235983)
+++ trunk/Source/WebKit/ChangeLog 2018-09-13 19:18:13 UTC (rev 235984)
@@ -1,3 +1,16 @@
+2018-09-13 Chris Dumez <[email protected]>
+
+ Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
+ https://bugs.webkit.org/show_bug.cgi?id=189587
+
+ Reviewed by Geoffrey Garen.
+
+ Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
+ as this is causing crashes on the bots.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::didCompletePageTransition):
+
2018-09-13 Ryan Haddad <[email protected]>
Unreviewed, rolling out r235953.
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (235983 => 235984)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-09-13 19:11:27 UTC (rev 235983)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-09-13 19:18:13 UTC (rev 235984)
@@ -2870,7 +2870,8 @@
void WebPage::didCompletePageTransition()
{
- m_drawingArea->setLayerTreeStateIsFrozen(false);
+ if (m_drawingArea)
+ m_drawingArea->setLayerTreeStateIsFrozen(false);
}
void WebPage::show()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
