Title: [236033] trunk/Source/WebInspectorUI
- Revision
- 236033
- Author
- [email protected]
- Date
- 2018-09-15 11:41:58 -0700 (Sat, 15 Sep 2018)
Log Message
Web Inspector: REGRESSION: breakpoint context menu appears twice in DOM tree
https://bugs.webkit.org/show_bug.cgi?id=189308
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/DOMBreakpointTreeController.js:
(WI.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
Set a symbol on the `contextMenu` to ensure that the same items are not added twice.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (236032 => 236033)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-09-15 16:17:24 UTC (rev 236032)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-09-15 18:41:58 UTC (rev 236033)
@@ -1,3 +1,14 @@
+2018-09-15 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION: breakpoint context menu appears twice in DOM tree
+ https://bugs.webkit.org/show_bug.cgi?id=189308
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/DOMBreakpointTreeController.js:
+ (WI.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
+ Set a symbol on the `contextMenu` to ensure that the same items are not added twice.
+
2018-09-14 Joseph Pecoraro <[email protected]>
Web Inspector: Source View doesn't scroll to show line when breakpoint is hit inside of <script> in HTML resource
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js (236032 => 236033)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js 2018-09-15 16:17:24 UTC (rev 236032)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMBreakpointTreeController.js 2018-09-15 18:41:58 UTC (rev 236033)
@@ -46,6 +46,11 @@
{
console.assert(WI.domDebuggerManager.supported);
+ if (contextMenu.__domBreakpointItemsAdded)
+ return;
+
+ contextMenu.__domBreakpointItemsAdded = true;
+
let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on…"));
let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
