Title: [236051] trunk/Source/WebKit
- Revision
- 236051
- Author
- [email protected]
- Date
- 2018-09-17 04:23:13 -0700 (Mon, 17 Sep 2018)
Log Message
Unreviewed, fix incorrect WPE build fix made in r236009
This isn't the right place to add the typedef. I failed to notice that the WebKitWebView
type is not actually used anywhere in this header. Actually, the problematic function is no
longer declared or used anywhere and was just missed when WebKitScriptDialog was refactored,
so remove it.
* UIProcess/API/wpe/WebKitScriptDialog.h:
* UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:
(webkitScriptDialogRun): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236050 => 236051)
--- trunk/Source/WebKit/ChangeLog 2018-09-17 11:06:44 UTC (rev 236050)
+++ trunk/Source/WebKit/ChangeLog 2018-09-17 11:23:13 UTC (rev 236051)
@@ -1,3 +1,16 @@
+2018-09-17 Michael Catanzaro <[email protected]>
+
+ Unreviewed, fix incorrect WPE build fix made in r236009
+
+ This isn't the right place to add the typedef. I failed to notice that the WebKitWebView
+ type is not actually used anywhere in this header. Actually, the problematic function is no
+ longer declared or used anywhere and was just missed when WebKitScriptDialog was refactored,
+ so remove it.
+
+ * UIProcess/API/wpe/WebKitScriptDialog.h:
+ * UIProcess/API/wpe/WebKitScriptDialogWPE.cpp:
+ (webkitScriptDialogRun): Deleted.
+
2018-09-17 Sihui Liu <[email protected]>
Move IndexedDB to Network Process
Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialog.h (236050 => 236051)
--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialog.h 2018-09-17 11:06:44 UTC (rev 236050)
+++ trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialog.h 2018-09-17 11:23:13 UTC (rev 236051)
@@ -32,7 +32,6 @@
#define WEBKIT_TYPE_SCRIPT_DIALOG (webkit_script_dialog_get_type())
typedef struct _WebKitScriptDialog WebKitScriptDialog;
-typedef struct _WebKitWebView WebKitWebView;
/**
* WebKitScriptDialogType:
Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp (236050 => 236051)
--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp 2018-09-17 11:06:44 UTC (rev 236050)
+++ trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp 2018-09-17 11:23:13 UTC (rev 236051)
@@ -22,10 +22,6 @@
#include "WebKitScriptDialogPrivate.h"
-void webkitScriptDialogRun(WebKitScriptDialog*, WebKitWebView*)
-{
-}
-
void webkitScriptDialogAccept(WebKitScriptDialog*)
{
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
