Title: [236072] trunk/LayoutTests
- Revision
- 236072
- Author
- [email protected]
- Date
- 2018-09-17 10:37:48 -0700 (Mon, 17 Sep 2018)
Log Message
[Web Animations] Positive delays of accelerated animations are not respected
https://bugs.webkit.org/show_bug.cgi?id=189411
<rdar://problem/44151416>
Reviewed by Dean Jackson.
Use a mask over the animated rectangle to allow for a 1px rounding error when seeking to fix flakiness.
* webanimations/accelerated-animation-with-delay-and-seek-expected.html:
* webanimations/accelerated-animation-with-delay-and-seek.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236071 => 236072)
--- trunk/LayoutTests/ChangeLog 2018-09-17 17:18:27 UTC (rev 236071)
+++ trunk/LayoutTests/ChangeLog 2018-09-17 17:37:48 UTC (rev 236072)
@@ -1,3 +1,16 @@
+2018-09-17 Antoine Quint <[email protected]>
+
+ [Web Animations] Positive delays of accelerated animations are not respected
+ https://bugs.webkit.org/show_bug.cgi?id=189411
+ <rdar://problem/44151416>
+
+ Reviewed by Dean Jackson.
+
+ Use a mask over the animated rectangle to allow for a 1px rounding error when seeking to fix flakiness.
+
+ * webanimations/accelerated-animation-with-delay-and-seek-expected.html:
+ * webanimations/accelerated-animation-with-delay-and-seek.html:
+
2018-09-17 Youenn Fablet <[email protected]>
Enable VCP for iOS and reenable it for MacOS
Modified: trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html (236071 => 236072)
--- trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html 2018-09-17 17:18:27 UTC (rev 236071)
+++ trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek-expected.html 2018-09-17 17:37:48 UTC (rev 236072)
@@ -3,15 +3,32 @@
<head>
<style>
div {
+ left: 0;
+ top: 0;
position: absolute;
+ height: 100px;
+}
+
+.mask {
+ /* We add an extra pixel to account for rounding errors */
+ width: 51px;
+ background-color: red;
+}
+
+#target {
width: 100px;
- height: 100px;
+ background-color: black;
transform: translateX(50px);
- background-color: black;
}
+
+#right {
+ left: 149px;
+}
</style>
</head>
<body>
-<div></div>
+<div id="target"></div>
+<div id="left" class="mask"></div>
+<div id="right" class="mask"></div>
</body>
</html>
Modified: trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html (236071 => 236072)
--- trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html 2018-09-17 17:18:27 UTC (rev 236071)
+++ trunk/LayoutTests/webanimations/accelerated-animation-with-delay-and-seek.html 2018-09-17 17:37:48 UTC (rev 236072)
@@ -4,21 +4,41 @@
<style>
div {
+ left: 0;
+ top: 0;
position: absolute;
+ height: 100px;
+}
+
+.mask {
+ /* We add an extra pixel to account for rounding errors */
+ width: 51px;
+ background-color: red;
+}
+
+#target {
width: 100px;
- height: 100px;
background-color: black;
}
+#right {
+ left: 149px;
+}
+
</style>
</head>
<body>
+
+<div id="target"></div>
+<div id="left" class="mask"></div>
+<div id="right" class="mask"></div>
+
<script>
if (window.testRunner)
testRunner.waitUntilDone();
-const animation = document.body.appendChild(document.createElement("div")).animate({
+const animation = document.getElementById("target").animate({
transform: ["translateX(100px)", "none"]
}, { duration: 10000, delay: 1000 });
@@ -25,8 +45,11 @@
requestAnimationFrame(() => {
animation.pause();
animation.currentTime = 6000;
- if (window.testRunner)
- requestAnimationFrame(() => testRunner.notifyDone());
+ if (window.testRunner) {
+ requestAnimationFrame(() => {
+ requestAnimationFrame(() => testRunner.notifyDone())
+ });
+ }
});
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
