[webkit-changes] [236083] trunk/Source/WebCore

Mon, 17 Sep 2018 14:08:28 -0700

Title: [236083] trunk/Source/WebCore
Revision
236083
Author
[email protected]
Date
2018-09-17 14:07:08 -0700 (Mon, 17 Sep 2018)

Log Message

Re-order Node flags based on semantics
https://bugs.webkit.org/show_bug.cgi?id=189643

Reviewed by Simon Fraser.

Re-ordered Node flags based on their category and subclasses of Node which use them.

* dom/Node.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (236082 => 236083)


--- trunk/Source/WebCore/ChangeLog	2018-09-17 20:50:43 UTC (rev 236082)
+++ trunk/Source/WebCore/ChangeLog	2018-09-17 21:07:08 UTC (rev 236083)
@@ -1,3 +1,14 @@
+2018-09-14  Ryosuke Niwa  <[email protected]>
+
+        Re-order Node flags based on semantics
+        https://bugs.webkit.org/show_bug.cgi?id=189643
+
+        Reviewed by Simon Fraser.
+
+        Re-ordered Node flags based on their category and subclasses of Node which use them.
+
+        * dom/Node.h:
+
 2018-09-17  Simon Fraser  <[email protected]>
 
         Add more ResourceLoading logging, particularly in MemoryCache code

Modified: trunk/Source/WebCore/dom/Node.h (236082 => 236083)


--- trunk/Source/WebCore/dom/Node.h	2018-09-17 20:50:43 UTC (rev 236082)
+++ trunk/Source/WebCore/dom/Node.h	2018-09-17 21:07:08 UTC (rev 236083)
@@ -559,10 +559,10 @@
         IsHTMLFlag = 1 << 3,
         IsSVGFlag = 1 << 4,
         IsMathMLFlag = 1 << 5,
-        IsConnectedFlag = 1 << 6,
-        IsInShadowTreeFlag = 1 << 7,
-        IsDocumentNodeFlag = 1 << 8,
-        IsShadowRootFlag = 1 << 9,
+        IsDocumentNodeFlag = 1 << 6,
+        IsShadowRootFlag = 1 << 7,
+        IsConnectedFlag = 1 << 8,
+        IsInShadowTreeFlag = 1 << 9,
         HasRareDataFlag = 1 << 10,
         HasEventTargetDataFlag = 1 << 11,
 
@@ -569,29 +569,31 @@
         // These bits are used by derived classes, pulled up here so they can
         // be stored in the same memory word as the Node bits above.
         ChildNeedsStyleRecalcFlag = 1 << 12, // ContainerNode
+        DirectChildNeedsStyleRecalcFlag = 1 << 13,
 
-        IsParsingChildrenFinishedFlag = 1 << 13, // Element
-        StyleValidityShift = 14,
+        IsEditingTextOrUndefinedCustomElementFlag = 1 << 14, // Text and Element
+        IsCustomElement = 1 << 15, // Element
+        HasFocusWithin = 1 << 16,
+        IsLinkFlag = 1 << 17,
+        IsUserActionElement = 1 << 18,
+        IsParsingChildrenFinishedFlag = 1 << 19,
+        HasSyntheticAttrChildNodesFlag = 1 << 20,
+        SelfOrAncestorHasDirAutoFlag = 1 << 21,
+
+        // The following flags are used in style invalidation.
+        StyleValidityShift = 22,
         StyleValidityMask = 3 << StyleValidityShift,
-        StyleResolutionShouldRecompositeLayerFlag = 1 << 16,
-        IsEditingTextOrUndefinedCustomElementFlag = 1 << 17,
-        HasFocusWithin = 1 << 18,
-        HasSyntheticAttrChildNodesFlag = 1 << 19,
-        HasCustomStyleResolveCallbacksFlag = 1 << 20,
-        DescendantsAffectedByPreviousSiblingFlag = 1 << 21,
-        IsCustomElement = 1 << 22,
-        IsLinkFlag = 1 << 23,
-        IsUserActionElement = 1 << 24,
+        StyleResolutionShouldRecompositeLayerFlag = 1 << 24,
 
         ChildrenAffectedByFirstChildRulesFlag = 1 << 25,
         ChildrenAffectedByLastChildRulesFlag = 1 << 26,
         ChildrenAffectedByHoverRulesFlag = 1 << 27,
 
-        DirectChildNeedsStyleRecalcFlag = 1 << 28,
-        AffectsNextSiblingElementStyle = 1 << 29,
-        StyleIsAffectedByPreviousSibling = 1 << 30,
+        AffectsNextSiblingElementStyle = 1 << 28,
+        StyleIsAffectedByPreviousSibling = 1 << 29,
+        DescendantsAffectedByPreviousSiblingFlag = 1 << 30,
 
-        SelfOrAncestorHasDirAutoFlag = 1 << 31,
+        HasCustomStyleResolveCallbacksFlag = 1 << 31,
 
         DefaultNodeFlags = IsParsingChildrenFinishedFlag
     };

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to