Title: [236144] trunk
- Revision
- 236144
- Author
- [email protected]
- Date
- 2018-09-18 10:11:17 -0700 (Tue, 18 Sep 2018)
Log Message
Enable Unified Plan by default
https://bugs.webkit.org/show_bug.cgi?id=189675
Reviewed by Eric Carlson.
Source/WebCore:
RTCRtpTransceiver.currentDirection is now gated by the unified plan runtime flag.
This will allow easy feature detection of unified plan support.
Covered by updated test.
* Modules/mediastream/RTCRtpTransceiver.idl:
Source/WebKit:
* Shared/WebPreferences.yaml:
LayoutTests:
* webrtc/video-addLegacyTransceiver-expected.txt:
* webrtc/video-addLegacyTransceiver.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236143 => 236144)
--- trunk/LayoutTests/ChangeLog 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/LayoutTests/ChangeLog 2018-09-18 17:11:17 UTC (rev 236144)
@@ -1,3 +1,13 @@
+2018-09-18 Youenn Fablet <[email protected]>
+
+ Enable Unified Plan by default
+ https://bugs.webkit.org/show_bug.cgi?id=189675
+
+ Reviewed by Eric Carlson.
+
+ * webrtc/video-addLegacyTransceiver-expected.txt:
+ * webrtc/video-addLegacyTransceiver.html:
+
2018-09-18 Per Arne Vollan <[email protected]>
[WebVTT] change "middle" to "center" for consistency with CSS
Modified: trunk/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt (236143 => 236144)
--- trunk/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/LayoutTests/webrtc/video-addLegacyTransceiver-expected.txt 2018-09-18 17:11:17 UTC (rev 236144)
@@ -1,5 +1,6 @@
+PASS Expose currentDirection only for unified plan
PASS Setting up calls with addTransceiver but with no track
PASS Setting up calls with addTransceiver with a track
PASS Basic video exchange set up with addTransceiver
Modified: trunk/LayoutTests/webrtc/video-addLegacyTransceiver.html (236143 => 236144)
--- trunk/LayoutTests/webrtc/video-addLegacyTransceiver.html 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/LayoutTests/webrtc/video-addLegacyTransceiver.html 2018-09-18 17:11:17 UTC (rev 236144)
@@ -14,6 +14,10 @@
if (window.testRunner)
testRunner.setWebRTCUnifiedPlanEnabled(false);
+test(() => {
+ assert_equals(Object.keys(RTCRtpTransceiver.prototype).indexOf("currentDirection"), -1, "No currentDirection if unified plan is off");
+}, "Expose currentDirection only for unified plan");
+
promise_test((test) => {
var pc = new RTCPeerConnection();
pc.addTransceiver("video");
Modified: trunk/Source/WebCore/ChangeLog (236143 => 236144)
--- trunk/Source/WebCore/ChangeLog 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/Source/WebCore/ChangeLog 2018-09-18 17:11:17 UTC (rev 236144)
@@ -1,3 +1,16 @@
+2018-09-18 Youenn Fablet <[email protected]>
+
+ Enable Unified Plan by default
+ https://bugs.webkit.org/show_bug.cgi?id=189675
+
+ Reviewed by Eric Carlson.
+
+ RTCRtpTransceiver.currentDirection is now gated by the unified plan runtime flag.
+ This will allow easy feature detection of unified plan support.
+ Covered by updated test.
+
+ * Modules/mediastream/RTCRtpTransceiver.idl:
+
2018-09-18 Per Arne Vollan <[email protected]>
[WebVTT] change "middle" to "center" for consistency with CSS
Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl (236143 => 236144)
--- trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl 2018-09-18 17:11:17 UTC (rev 236144)
@@ -40,7 +40,7 @@
[SameObject] readonly attribute RTCRtpReceiver receiver;
readonly attribute boolean stopped;
readonly attribute RtpTransceiverDirection direction;
- readonly attribute RTCRtpTransceiverDirection? currentDirection;
+ [EnabledAtRuntime=WebRTCUnifiedPlan] readonly attribute RTCRtpTransceiverDirection? currentDirection;
void setDirection(RtpTransceiverDirection direction);
void stop();
// FIXME 169662: missing setCodecPreferences
Modified: trunk/Source/WebKit/ChangeLog (236143 => 236144)
--- trunk/Source/WebKit/ChangeLog 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/Source/WebKit/ChangeLog 2018-09-18 17:11:17 UTC (rev 236144)
@@ -1,3 +1,12 @@
+2018-09-18 Youenn Fablet <[email protected]>
+
+ Enable Unified Plan by default
+ https://bugs.webkit.org/show_bug.cgi?id=189675
+
+ Reviewed by Eric Carlson.
+
+ * Shared/WebPreferences.yaml:
+
2018-09-18 Antti Koivisto <[email protected]>
REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (236143 => 236144)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-18 16:07:24 UTC (rev 236143)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2018-09-18 17:11:17 UTC (rev 236144)
@@ -496,7 +496,7 @@
WebRTCUnifiedPlanEnabled:
type: bool
- defaultValue: false
+ defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
webcoreBinding: RuntimeEnabledFeatures
condition: ENABLE(WEB_RTC)
humanReadableName: "WebRTC Unified Plan"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
