Title: [236211] trunk
- Revision
- 236211
- Author
- [email protected]
- Date
- 2018-09-19 10:17:34 -0700 (Wed, 19 Sep 2018)
Log Message
Layout Test webrtc/video-mute.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=177501
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated test expectation.
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
(WebCore::createBlackPixelBuffer): Make sure the whole buffer is properly initialized.
LayoutTests:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* webrtc/routines.js: Increase counter to make test more robust.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236210 => 236211)
--- trunk/LayoutTests/ChangeLog 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/LayoutTests/ChangeLog 2018-09-19 17:17:34 UTC (rev 236211)
@@ -1,3 +1,14 @@
+2018-09-19 Youenn Fablet <[email protected]>
+
+ Layout Test webrtc/video-mute.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=177501
+
+ Reviewed by Eric Carlson.
+
+ * platform/ios-wk2/TestExpectations:
+ * platform/mac-wk2/TestExpectations:
+ * webrtc/routines.js: Increase counter to make test more robust.
+
2018-09-19 Chris Dumez <[email protected]>
[iOS] Layout Test imported/w3c/web-platform-tests/beacon/beacon-basic-blob.html is a flaky failure
Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (236210 => 236211)
--- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2018-09-19 17:17:34 UTC (rev 236211)
@@ -1234,8 +1234,6 @@
webkit.org/b/173608 webrtc/video-replace-muted-track.html [ Skip ]
-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
-
webkit.org/b/187388 animations/needs-layout.html [ Pass ImageOnlyFailure ]
webkit.org/b/172397 legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (236210 => 236211)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-09-19 17:17:34 UTC (rev 236211)
@@ -783,8 +783,6 @@
webkit.org/b/178553 [ HighSierra Release ] imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011.html [ Skip ]
-webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
-
webkit.org/b/165620 [ Sierra ] http/tests/cache/disk-cache/disk-cache-request-headers.html [ Pass Failure ]
webkit.org/b/179773 imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html [ Pass Failure ]
Modified: trunk/LayoutTests/webrtc/routines.js (236210 => 236211)
--- trunk/LayoutTests/webrtc/routines.js 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/LayoutTests/webrtc/routines.js 2018-09-19 17:17:34 UTC (rev 236211)
@@ -195,7 +195,7 @@
if (counter === undefined)
counter = 0;
- if (counter > 50) {
+ if (counter > 400) {
if (!errorMessage)
errorMessage = "checkVideoBlack timed out expecting " + expected;
return Promise.reject(errorMessage);
Modified: trunk/Source/WebCore/ChangeLog (236210 => 236211)
--- trunk/Source/WebCore/ChangeLog 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/Source/WebCore/ChangeLog 2018-09-19 17:17:34 UTC (rev 236211)
@@ -1,3 +1,15 @@
+2018-09-19 Youenn Fablet <[email protected]>
+
+ Layout Test webrtc/video-mute.html is flaky.
+ https://bugs.webkit.org/show_bug.cgi?id=177501
+
+ Reviewed by Eric Carlson.
+
+ Covered by updated test expectation.
+
+ * platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
+ (WebCore::createBlackPixelBuffer): Make sure the whole buffer is properly initialized.
+
2018-09-19 David Kilzer <[email protected]>
WebCoreNSURLSession leaks an NSString (_sessionDescription) in -dealloc
Modified: trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm (236210 => 236211)
--- trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm 2018-09-19 16:27:06 UTC (rev 236210)
+++ trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm 2018-09-19 17:17:34 UTC (rev 236211)
@@ -73,10 +73,13 @@
status = CVPixelBufferLockBaseAddress(pixelBuffer, 0);
ASSERT(status == noErr);
void* data = ""
+
size_t yLength = width * height;
memset(data, 0, yLength);
- memset(static_cast<uint8_t*>(data) + yLength, 128, yLength / 2);
+ auto totalSize = CVPixelBufferGetDataSize(pixelBuffer);
+ memset(static_cast<uint8_t*>(data) + yLength, 128, totalSize - yLength);
+
status = CVPixelBufferUnlockBaseAddress(pixelBuffer, 0);
ASSERT(!status);
return adoptCF(pixelBuffer);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
