Title: [236232] trunk/Source/WebKit
- Revision
- 236232
- Author
- [email protected]
- Date
- 2018-09-19 17:13:25 -0700 (Wed, 19 Sep 2018)
Log Message
REGRESSION(236154) C API clients not using WKPageSetPageNavigationClient couldn't complete HTTPS requests
https://bugs.webkit.org/show_bug.cgi?id=189771
Reviewed by Tim Horton.
* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didReceiveAuthenticationChallenge):
Perform default behavior if there's an authentication challenge but we're using the default navigation client.
I wish we had infrastructure to test this but WebKitTestRunner uses WKPageSetNavigationClient
and we don't have the ability to do networking from API tests. This is a growing problem I intend to solve.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236231 => 236232)
--- trunk/Source/WebKit/ChangeLog 2018-09-19 23:58:33 UTC (rev 236231)
+++ trunk/Source/WebKit/ChangeLog 2018-09-20 00:13:25 UTC (rev 236232)
@@ -1,3 +1,16 @@
+2018-09-19 Alex Christensen <[email protected]>
+
+ REGRESSION(236154) C API clients not using WKPageSetPageNavigationClient couldn't complete HTTPS requests
+ https://bugs.webkit.org/show_bug.cgi?id=189771
+
+ Reviewed by Tim Horton.
+
+ * UIProcess/API/APINavigationClient.h:
+ (API::NavigationClient::didReceiveAuthenticationChallenge):
+ Perform default behavior if there's an authentication challenge but we're using the default navigation client.
+ I wish we had infrastructure to test this but WebKitTestRunner uses WKPageSetNavigationClient
+ and we don't have the ability to do networking from API tests. This is a growing problem I intend to solve.
+
2018-09-19 Woodrow Wang <[email protected]>
Clear persistent storage between tests for resourceLoadStatistics
Modified: trunk/Source/WebKit/UIProcess/API/APINavigationClient.h (236231 => 236232)
--- trunk/Source/WebKit/UIProcess/API/APINavigationClient.h 2018-09-19 23:58:33 UTC (rev 236231)
+++ trunk/Source/WebKit/UIProcess/API/APINavigationClient.h 2018-09-20 00:13:25 UTC (rev 236232)
@@ -27,6 +27,8 @@
#include "APIData.h"
#include "APIString.h"
+#include "AuthenticationChallengeProxy.h"
+#include "AuthenticationDecisionListener.h"
#include "PluginModuleInfo.h"
#include "ProcessTerminationReason.h"
#include "SameDocumentNavigationType.h"
@@ -85,8 +87,7 @@
virtual void renderingProgressDidChange(WebKit::WebPageProxy&, WebCore::LayoutMilestones) { }
- virtual bool canAuthenticateAgainstProtectionSpace(WebKit::WebPageProxy&, WebKit::WebProtectionSpace*) { return false; }
- virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy&) { }
+ virtual void didReceiveAuthenticationChallenge(WebKit::WebPageProxy&, WebKit::AuthenticationChallengeProxy& challenge) { challenge.listener().performDefaultHandling(); }
// FIXME: These function should not be part of this client.
virtual bool processDidTerminate(WebKit::WebPageProxy&, WebKit::ProcessTerminationReason) { return false; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
