Title: [236262] trunk/Source/WebKit
- Revision
- 236262
- Author
- [email protected]
- Date
- 2018-09-20 09:13:42 -0700 (Thu, 20 Sep 2018)
Log Message
Unreviewed crash fix after r236226.
We need to protect |this| in WebProcessProxy::requestTermination().
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236261 => 236262)
--- trunk/Source/WebKit/ChangeLog 2018-09-20 16:12:30 UTC (rev 236261)
+++ trunk/Source/WebKit/ChangeLog 2018-09-20 16:13:42 UTC (rev 236262)
@@ -1,3 +1,12 @@
+2018-09-20 Chris Dumez <[email protected]>
+
+ Unreviewed crash fix after r236226.
+
+ We need to protect |this| in WebProcessProxy::requestTermination().
+
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::requestTermination):
+
2018-09-20 Antti Koivisto <[email protected]>
REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (236261 => 236262)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2018-09-20 16:12:30 UTC (rev 236261)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2018-09-20 16:13:42 UTC (rev 236262)
@@ -997,6 +997,7 @@
if (state() == State::Terminated)
return;
+ auto protectedThis = makeRef(*this);
RELEASE_LOG_IF(m_websiteDataStore->sessionID().isAlwaysOnLoggingAllowed(), Process, "%p - WebProcessProxy::requestTermination - reason %d", this, reason);
ChildProcessProxy::terminate();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
