Title: [236279] trunk/Source/WebKit
- Revision
- 236279
- Author
- [email protected]
- Date
- 2018-09-20 13:47:28 -0700 (Thu, 20 Sep 2018)
Log Message
[GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled are always synced with enable-media-stream
https://bugs.webkit.org/show_bug.cgi?id=188704
By default m_isMediaDevicesEnabled and m_isScreenCaptureEnabled are false but
m_isMediaStreamEnabled is true meaning that in the WPE minibrowser getUserMedia
was disabled even if we explicitly set `"enable-media-stream", TRUE`.
Patch by Thibault Saunier <[email protected]> on 2018-09-20
Reviewed by Michael Catanzaro.
* UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsConstructed):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236278 => 236279)
--- trunk/Source/WebKit/ChangeLog 2018-09-20 20:43:36 UTC (rev 236278)
+++ trunk/Source/WebKit/ChangeLog 2018-09-20 20:47:28 UTC (rev 236279)
@@ -1,3 +1,17 @@
+2018-09-20 Thibault Saunier <[email protected]>
+
+ [GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled are always synced with enable-media-stream
+ https://bugs.webkit.org/show_bug.cgi?id=188704
+
+ By default m_isMediaDevicesEnabled and m_isScreenCaptureEnabled are false but
+ m_isMediaStreamEnabled is true meaning that in the WPE minibrowser getUserMedia
+ was disabled even if we explicitly set `"enable-media-stream", TRUE`.
+
+ Reviewed by Michael Catanzaro.
+
+ * UIProcess/API/glib/WebKitSettings.cpp:
+ (webKitSettingsConstructed):
+
2018-09-20 Justin Michaud <[email protected]>
Implement CSS Custom Properties and Values Skeleton
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (236278 => 236279)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2018-09-20 20:43:36 UTC (rev 236278)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2018-09-20 20:47:28 UTC (rev 236279)
@@ -177,6 +177,10 @@
WebPreferences* prefs = settings->priv->preferences.get();
prefs->setShouldRespectImageOrientation(true);
+ bool mediaStreamEnabled = prefs->mediaStreamEnabled();
+ prefs->setMediaDevicesEnabled(mediaStreamEnabled);
+ prefs->setPeerConnectionEnabled(mediaStreamEnabled);
+
settings->priv->screenDpi = WebCore::screenDPI();
WebCore::setScreenDPIObserverHandler([settings]() {
auto newScreenDpi = WebCore::screenDPI();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
