Title: [236302] trunk/Source/WTF
- Revision
- 236302
- Author
- [email protected]
- Date
- 2018-09-20 19:49:50 -0700 (Thu, 20 Sep 2018)
Log Message
[Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"
https://bugs.webkit.org/show_bug.cgi?id=189732
Reviewed by Per Arne Vollan.
Clang for Windows can't compile the MSVC workaround of
UNUSED_PARAM which has been introduced for Windows CE and Visual
Studio 10. I think it's safe just to remove it.
* wtf/Compiler.h: Removed the code for COMPILER(MSVC).
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (236301 => 236302)
--- trunk/Source/WTF/ChangeLog 2018-09-21 02:23:37 UTC (rev 236301)
+++ trunk/Source/WTF/ChangeLog 2018-09-21 02:49:50 UTC (rev 236302)
@@ -1,3 +1,16 @@
+2018-09-20 Fujii Hironori <[email protected]>
+
+ [Win][Clang] UNUSED_PARAM(this) causes compilation error of "cannot take the address of an rvalue of type"
+ https://bugs.webkit.org/show_bug.cgi?id=189732
+
+ Reviewed by Per Arne Vollan.
+
+ Clang for Windows can't compile the MSVC workaround of
+ UNUSED_PARAM which has been introduced for Windows CE and Visual
+ Studio 10. I think it's safe just to remove it.
+
+ * wtf/Compiler.h: Removed the code for COMPILER(MSVC).
+
2018-09-20 Alex Christensen <[email protected]>
Unreviewed, rolling out r235976.
Modified: trunk/Source/WTF/wtf/Compiler.h (236301 => 236302)
--- trunk/Source/WTF/wtf/Compiler.h 2018-09-21 02:23:37 UTC (rev 236301)
+++ trunk/Source/WTF/wtf/Compiler.h 2018-09-21 02:49:50 UTC (rev 236302)
@@ -363,10 +363,6 @@
/* UNUSED_PARAM */
-#if !defined(UNUSED_PARAM) && COMPILER(MSVC)
-#define UNUSED_PARAM(variable) (void)&variable
-#endif
-
#if !defined(UNUSED_PARAM)
#define UNUSED_PARAM(variable) (void)variable
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
