Title: [236315] trunk/Source/_javascript_Core
- Revision
- 236315
- Author
- [email protected]
- Date
- 2018-09-21 07:35:38 -0700 (Fri, 21 Sep 2018)
Log Message
[ARM] Build broken on armv7hl after r235517
https://bugs.webkit.org/show_bug.cgi?id=189831
Reviewed by Yusuke Suzuki.
Add missing implementation of patchebleBranch8() for traditional ARM.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableBranch8):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236314 => 236315)
--- trunk/Source/_javascript_Core/ChangeLog 2018-09-21 13:47:48 UTC (rev 236314)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-09-21 14:35:38 UTC (rev 236315)
@@ -1,3 +1,15 @@
+2018-09-21 Tomas Popela <[email protected]>
+
+ [ARM] Build broken on armv7hl after r235517
+ https://bugs.webkit.org/show_bug.cgi?id=189831
+
+ Reviewed by Yusuke Suzuki.
+
+ Add missing implementation of patchebleBranch8() for traditional ARM.
+
+ * assembler/MacroAssemblerARM.h:
+ (JSC::MacroAssemblerARM::patchableBranch8):
+
2018-09-20 Ryan Haddad <[email protected]>
Unreviewed, rolling out r236293.
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (236314 => 236315)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2018-09-21 13:47:48 UTC (rev 236314)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2018-09-21 14:35:38 UTC (rev 236315)
@@ -981,6 +981,13 @@
return PatchableJump(m_assembler.jmp(ARMAssembler::AL, 1));
}
+ PatchableJump patchableBranch8(RelationalCondition cond, Address address, TrustedImm32 imm)
+ {
+ TrustedImm32 imm8 = MacroAssemblerHelpers::mask8OnCondition(*this, cond, imm);
+ MacroAssemblerHelpers::load8OnCondition(*this, cond, address, dataTempRegister);
+ return patchableBranch32(cond, dataTempRegister, imm8);
+ }
+
PatchableJump patchableBranch32(RelationalCondition cond, RegisterID reg, TrustedImm32 imm)
{
internalCompare32(reg, imm);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
