Title: [236380] trunk/LayoutTests
- Revision
- 236380
- Author
- [email protected]
- Date
- 2018-09-21 19:03:51 -0700 (Fri, 21 Sep 2018)
Log Message
Web Inspector: REGRESSION(r236336): computed CSSProperty doesn't have a value for _text
https://bugs.webkit.org/show_bug.cgi?id=189864
Reviewed by Joseph Pecoraro.
* inspector/css/pseudo-element-matches-for-pseudo-element-node.html:
`CSS.types.CSSComputedStyleProperty` doesn't include a `text` value, which was used to print
each property's text. Modify the test to generate it's own text via `name` and `value`.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236379 => 236380)
--- trunk/LayoutTests/ChangeLog 2018-09-22 01:03:48 UTC (rev 236379)
+++ trunk/LayoutTests/ChangeLog 2018-09-22 02:03:51 UTC (rev 236380)
@@ -1,3 +1,15 @@
+2018-09-21 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r236336): computed CSSProperty doesn't have a value for _text
+ https://bugs.webkit.org/show_bug.cgi?id=189864
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/css/pseudo-element-matches-for-pseudo-element-node.html:
+
+ `CSS.types.CSSComputedStyleProperty` doesn't include a `text` value, which was used to print
+ each property's text. Modify the test to generate it's own text via `name` and `value`.
+
2018-09-21 Justin Michaud <[email protected]>
Implement initialValue support for CSS Custom Properties and Values API
Modified: trunk/LayoutTests/inspector/css/pseudo-element-matches-for-pseudo-element-node.html (236379 => 236380)
--- trunk/LayoutTests/inspector/css/pseudo-element-matches-for-pseudo-element-node.html 2018-09-22 01:03:48 UTC (rev 236379)
+++ trunk/LayoutTests/inspector/css/pseudo-element-matches-for-pseudo-element-node.html 2018-09-22 02:03:51 UTC (rev 236380)
@@ -15,9 +15,16 @@
InspectorTest.expectThat(!Object.keys(nodeStyles.pseudoElements).length, "No Pseudo Element Styles");
InspectorTest.expectThat(nodeStyles.computedStyle, "Has Computed Styles");
- InspectorTest.log("PROPERTY: " + nodeStyles.computedStyle.propertyForName("content").text);
- InspectorTest.log("PROPERTY: " + nodeStyles.computedStyle.propertyForName("color").text);
+ function logProperty(propertyName) {
+ const dontCreateIfMissing = true;
+ let property = nodeStyles.computedStyle.propertyForName(propertyName, dontCreateIfMissing);
+ InspectorTest.log(`PROPERTY: ${property.name}: ${property.value};`);
+ }
+
+ logProperty("content");
+ logProperty("color");
+
for (var rule of nodeStyles.matchedRules) {
InspectorTest.log("MATCHED RULE:");
for (var i = 0; i < rule.selectors.length; ++i) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
