Title: [236410] trunk
- Revision
- 236410
- Author
- [email protected]
- Date
- 2018-09-24 10:35:39 -0700 (Mon, 24 Sep 2018)
Log Message
Ensure PointerEvent is not visible when disabled
https://bugs.webkit.org/show_bug.cgi?id=189889
<rdar://problem/44708253>
Reviewed by Eric Carlson.
Source/WebCore:
Test: pointerevents/disabled.html
* bindings/js/WebCoreBuiltinNames.h: Now that it is enabled at runtime, it needs
a built-in name.
* dom/PointerEvent.idl: Add EnabledAtRuntime.
LayoutTests:
A test that explicitly disables PointerEvents and checks
that the interface is not visible.
* pointerevents/disabled-expected.html: Added.
* pointerevents/disabled.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (236409 => 236410)
--- trunk/LayoutTests/ChangeLog 2018-09-24 17:26:03 UTC (rev 236409)
+++ trunk/LayoutTests/ChangeLog 2018-09-24 17:35:39 UTC (rev 236410)
@@ -1,3 +1,17 @@
+2018-09-22 Dean Jackson <[email protected]>
+
+ Ensure PointerEvent is not visible when disabled
+ https://bugs.webkit.org/show_bug.cgi?id=189889
+ <rdar://problem/44708253>
+
+ Reviewed by Eric Carlson.
+
+ A test that explicitly disables PointerEvents and checks
+ that the interface is not visible.
+
+ * pointerevents/disabled-expected.html: Added.
+ * pointerevents/disabled.html: Added.
+
2018-09-24 Truitt Savell <[email protected]>
[ iOS ] Layout Tests in media/media-fragments/ are flaky - Remved Debug only as tests are flakey on Release.
Added: trunk/LayoutTests/pointerevents/disabled-expected.html (0 => 236410)
--- trunk/LayoutTests/pointerevents/disabled-expected.html (rev 0)
+++ trunk/LayoutTests/pointerevents/disabled-expected.html 2018-09-24 17:35:39 UTC (rev 236410)
@@ -0,0 +1,3 @@
+<!DOCTYPE html>
+<p>The PointerEvent interface shouldn't be visible when the feature is disabled.</p>
+<p>window.PointerEvent == <span>undefined</span></p>
Property changes on: trunk/LayoutTests/pointerevents/disabled-expected.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Added: trunk/LayoutTests/pointerevents/disabled.html (0 => 236410)
--- trunk/LayoutTests/pointerevents/disabled.html (rev 0)
+++ trunk/LayoutTests/pointerevents/disabled.html 2018-09-24 17:35:39 UTC (rev 236410)
@@ -0,0 +1,9 @@
+<!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=false ] -->
+<p>The PointerEvent interface shouldn't be visible when the feature is disabled.</p>
+<p>window.PointerEvent == <span></span></p>
+<script>
+window.addEventListener("load", () => {
+ const output = document.querySelector("span");
+ output.textContent = `${window.PointerEvent}`;
+}, false);
+</script>
Property changes on: trunk/LayoutTests/pointerevents/disabled.html
___________________________________________________________________
Added: svn:eol-style
+native
\ No newline at end of property
Added: svn:keywords
+Date Revision
\ No newline at end of property
Added: svn:mime-type
+text/html
\ No newline at end of property
Modified: trunk/Source/WebCore/ChangeLog (236409 => 236410)
--- trunk/Source/WebCore/ChangeLog 2018-09-24 17:26:03 UTC (rev 236409)
+++ trunk/Source/WebCore/ChangeLog 2018-09-24 17:35:39 UTC (rev 236410)
@@ -1,3 +1,17 @@
+2018-09-22 Dean Jackson <[email protected]>
+
+ Ensure PointerEvent is not visible when disabled
+ https://bugs.webkit.org/show_bug.cgi?id=189889
+ <rdar://problem/44708253>
+
+ Reviewed by Eric Carlson.
+
+ Test: pointerevents/disabled.html
+
+ * bindings/js/WebCoreBuiltinNames.h: Now that it is enabled at runtime, it needs
+ a built-in name.
+ * dom/PointerEvent.idl: Add EnabledAtRuntime.
+
2018-09-24 Alicia Boya García <[email protected]>
[MSE][GStreamer] Pull demuxed samples in batches
Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (236409 => 236410)
--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2018-09-24 17:26:03 UTC (rev 236409)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h 2018-09-24 17:35:39 UTC (rev 236410)
@@ -120,6 +120,7 @@
macro(PerformanceObserverEntryList) \
macro(PerformanceResourceTiming) \
macro(PerformanceServerTiming) \
+ macro(PointerEvent) \
macro(PublicKeyCredential) \
macro(RTCDTMFSender) \
macro(RTCDTMFToneChangeEvent) \
Modified: trunk/Source/WebCore/dom/PointerEvent.idl (236409 => 236410)
--- trunk/Source/WebCore/dom/PointerEvent.idl 2018-09-24 17:26:03 UTC (rev 236409)
+++ trunk/Source/WebCore/dom/PointerEvent.idl 2018-09-24 17:35:39 UTC (rev 236410)
@@ -36,9 +36,11 @@
boolean isPrimary = false;
};
-[Constructor(DOMString type, optional PointerEventInit eventInitDict),
- Exposed=Window]
-interface PointerEvent : MouseEvent {
+[
+ EnabledAtRuntime=PointerEvents,
+ Constructor(DOMString type, optional PointerEventInit eventInitDict),
+ Exposed=Window
+] interface PointerEvent : MouseEvent {
readonly attribute long pointerId;
readonly attribute double width;
readonly attribute double height;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
