Title: [236413] trunk/Source/WebCore
- Revision
- 236413
- Author
- [email protected]
- Date
- 2018-09-24 11:10:19 -0700 (Mon, 24 Sep 2018)
Log Message
ReferenceFilterOperation doesn't need to store the FilterEffect
https://bugs.webkit.org/show_bug.cgi?id=189904
Reviewed by Dean Jackson.
ReferenceFilterOperation doesn't do anything with m_filterEffect so don't store it.
* platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::setFilterEffect): Deleted.
* platform/graphics/filters/FilterOperation.h:
(WebCore::ReferenceFilterOperation::filterEffect const): Deleted.
* rendering/CSSFilter.cpp:
(WebCore::CSSFilter::build):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236412 => 236413)
--- trunk/Source/WebCore/ChangeLog 2018-09-24 18:00:31 UTC (rev 236412)
+++ trunk/Source/WebCore/ChangeLog 2018-09-24 18:10:19 UTC (rev 236413)
@@ -1,5 +1,21 @@
2018-09-24 Simon Fraser <[email protected]>
+ ReferenceFilterOperation doesn't need to store the FilterEffect
+ https://bugs.webkit.org/show_bug.cgi?id=189904
+
+ Reviewed by Dean Jackson.
+
+ ReferenceFilterOperation doesn't do anything with m_filterEffect so don't store it.
+
+ * platform/graphics/filters/FilterOperation.cpp:
+ (WebCore::ReferenceFilterOperation::setFilterEffect): Deleted.
+ * platform/graphics/filters/FilterOperation.h:
+ (WebCore::ReferenceFilterOperation::filterEffect const): Deleted.
+ * rendering/CSSFilter.cpp:
+ (WebCore::CSSFilter::build):
+
+2018-09-24 Simon Fraser <[email protected]>
+
Garbled rendering of image when applied feConvolveMatrix to it, on Retina display
https://bugs.webkit.org/show_bug.cgi?id=189748
<rdar://problem/44621494>
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterOperation.cpp (236412 => 236413)
--- trunk/Source/WebCore/platform/graphics/filters/FilterOperation.cpp 2018-09-24 18:00:31 UTC (rev 236412)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterOperation.cpp 2018-09-24 18:10:19 UTC (rev 236413)
@@ -71,11 +71,6 @@
m_cachedSVGDocumentReference->load(cachedResourceLoader, options);
}
-void ReferenceFilterOperation::setFilterEffect(RefPtr<FilterEffect>&& filterEffect)
-{
- m_filterEffect = WTFMove(filterEffect);
-}
-
RefPtr<FilterOperation> BasicColorMatrixFilterOperation::blend(const FilterOperation* from, double progress, bool blendToPassthrough)
{
if (from && !from->isSameType(*this))
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h (236412 => 236413)
--- trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2018-09-24 18:00:31 UTC (rev 236412)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterOperation.h 2018-09-24 18:10:19 UTC (rev 236413)
@@ -189,9 +189,6 @@
CachedSVGDocumentReference* cachedSVGDocumentReference() const { return m_cachedSVGDocumentReference.get(); }
- FilterEffect* filterEffect() const { return m_filterEffect.get(); }
- void setFilterEffect(RefPtr<FilterEffect>&&);
-
private:
ReferenceFilterOperation(const String& url, const String& fragment);
@@ -200,7 +197,6 @@
String m_url;
String m_fragment;
std::unique_ptr<CachedSVGDocumentReference> m_cachedSVGDocumentReference;
- RefPtr<FilterEffect> m_filterEffect;
};
// GRAYSCALE, SEPIA, SATURATE and HUE_ROTATE are variations on a basic color matrix effect.
Modified: trunk/Source/WebCore/rendering/CSSFilter.cpp (236412 => 236413)
--- trunk/Source/WebCore/rendering/CSSFilter.cpp 2018-09-24 18:00:31 UTC (rev 236412)
+++ trunk/Source/WebCore/rendering/CSSFilter.cpp 2018-09-24 18:10:19 UTC (rev 236413)
@@ -144,7 +144,6 @@
case FilterOperation::REFERENCE: {
auto& referenceOperation = downcast<ReferenceFilterOperation>(filterOperation);
effect = buildReferenceFilter(renderer, *previousEffect, referenceOperation);
- referenceOperation.setFilterEffect(effect.copyRef());
break;
}
case FilterOperation::GRAYSCALE: {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
