Title: [236432] trunk/Source/WebCore
- Revision
- 236432
- Author
- [email protected]
- Date
- 2018-09-24 15:47:35 -0700 (Mon, 24 Sep 2018)
Log Message
Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
https://bugs.webkit.org/show_bug.cgi?id=189928
Reviewed by Andy Estes.
Make building IOSurface.mm and PixelBufferResizer.mm deterministic regardless of
which bundle of unified sources they are built in.
* platform/graphics/cocoa/IOSurface.mm: Include headers HostWindow.h and PlatformScreen.h
since we make use of functionality from these headers.
* platform/graphics/cv/PixelBufferResizer.h: Include header IntSize.h since
we need the size of an IntSize for m_size.
* platform/graphics/cv/PixelBufferResizer.mm: Include header Logging.h since
this file makes use of logging facilities. Also substitute #import for #include
while I am here since this file is an Objective-C++ file.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236431 => 236432)
--- trunk/Source/WebCore/ChangeLog 2018-09-24 22:40:43 UTC (rev 236431)
+++ trunk/Source/WebCore/ChangeLog 2018-09-24 22:47:35 UTC (rev 236432)
@@ -1,3 +1,21 @@
+2018-09-24 Daniel Bates <[email protected]>
+
+ Include more headers in IOSurface.mm, PixelBufferResizer.{h, mm}
+ https://bugs.webkit.org/show_bug.cgi?id=189928
+
+ Reviewed by Andy Estes.
+
+ Make building IOSurface.mm and PixelBufferResizer.mm deterministic regardless of
+ which bundle of unified sources they are built in.
+
+ * platform/graphics/cocoa/IOSurface.mm: Include headers HostWindow.h and PlatformScreen.h
+ since we make use of functionality from these headers.
+ * platform/graphics/cv/PixelBufferResizer.h: Include header IntSize.h since
+ we need the size of an IntSize for m_size.
+ * platform/graphics/cv/PixelBufferResizer.mm: Include header Logging.h since
+ this file makes use of logging facilities. Also substitute #import for #include
+ while I am here since this file is an Objective-C++ file.
+
2018-09-24 Andy Estes <[email protected]>
[Payment Request] Events cleanup
Modified: trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm (236431 => 236432)
--- trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2018-09-24 22:40:43 UTC (rev 236431)
+++ trunk/Source/WebCore/platform/graphics/cocoa/IOSurface.mm 2018-09-24 22:47:35 UTC (rev 236432)
@@ -30,10 +30,12 @@
#import "GraphicsContext3D.h"
#import "GraphicsContextCG.h"
+#import "HostWindow.h"
#import "IOSurfacePool.h"
#import "ImageBuffer.h"
#import "ImageBufferDataCG.h"
#import "Logging.h"
+#import "PlatformScreen.h"
#import <pal/spi/cg/CoreGraphicsSPI.h>
#import <pal/spi/cocoa/IOSurfaceSPI.h>
#import <wtf/Assertions.h>
Modified: trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.h (236431 => 236432)
--- trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.h 2018-09-24 22:40:43 UTC (rev 236431)
+++ trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.h 2018-09-24 22:47:35 UTC (rev 236432)
@@ -27,6 +27,7 @@
#if USE(VIDEOTOOLBOX)
+#include "IntSize.h"
#include <wtf/RetainPtr.h>
typedef struct OpaqueVTPixelTransferSession* VTPixelTransferSessionRef;
Modified: trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.mm (236431 => 236432)
--- trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.mm 2018-09-24 22:40:43 UTC (rev 236431)
+++ trunk/Source/WebCore/platform/graphics/cv/PixelBufferResizer.mm 2018-09-24 22:47:35 UTC (rev 236432)
@@ -23,15 +23,16 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#include "config.h"
-#include "PixelBufferResizer.h"
+#import "config.h"
+#import "PixelBufferResizer.h"
#if USE(VIDEOTOOLBOX)
-#include <wtf/SoftLinking.h>
+#import "Logging.h"
+#import <wtf/SoftLinking.h>
-#include "CoreVideoSoftLink.h"
-#include "VideoToolboxSoftLink.h"
+#import "CoreVideoSoftLink.h"
+#import "VideoToolboxSoftLink.h"
namespace WebCore {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes