Title: [236518] trunk/Tools
- Revision
- 236518
- Author
- [email protected]
- Date
- 2018-09-26 12:47:46 -0700 (Wed, 26 Sep 2018)
Log Message
MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
https://bugs.webkit.org/show_bug.cgi?id=189989
Reviewed by Simon Fraser.
When the preference isn't found in user defaults, use the default value of each feature's enabledness.
* MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (236517 => 236518)
--- trunk/Tools/ChangeLog 2018-09-26 19:29:54 UTC (rev 236517)
+++ trunk/Tools/ChangeLog 2018-09-26 19:47:46 UTC (rev 236518)
@@ -1,3 +1,15 @@
+2018-09-26 Ryosuke Niwa <[email protected]>
+
+ MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
+ https://bugs.webkit.org/show_bug.cgi?id=189989
+
+ Reviewed by Simon Fraser.
+
+ When the preference isn't found in user defaults, use the default value of each feature's enabledness.
+
+ * MiniBrowser/mac/AppDelegate.m:
+ (defaultConfiguration):
+
2018-09-26 Philippe Normand <[email protected]>
[Flatpak] Bump to apr 1.6.5
Modified: trunk/Tools/MiniBrowser/mac/AppDelegate.m (236517 => 236518)
--- trunk/Tools/MiniBrowser/mac/AppDelegate.m 2018-09-26 19:29:54 UTC (rev 236517)
+++ trunk/Tools/MiniBrowser/mac/AppDelegate.m 2018-09-26 19:47:46 UTC (rev 236518)
@@ -109,13 +109,21 @@
#if WK_API_ENABLED
NSArray<_WKExperimentalFeature *> *experimentalFeatures = [WKPreferences _experimentalFeatures];
for (_WKExperimentalFeature *feature in experimentalFeatures) {
- BOOL enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+ BOOL enabled;
+ if ([[NSUserDefaults standardUserDefaults] objectForKey:feature.key])
+ enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+ else
+ enabled = [feature defaultValue];
[configuration.preferences _setEnabled:enabled forExperimentalFeature:feature];
}
NSArray<_WKInternalDebugFeature *> *internalDebugFeatures = [WKPreferences _internalDebugFeatures];
for (_WKInternalDebugFeature *feature in internalDebugFeatures) {
- BOOL enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+ BOOL enabled;
+ if ([[NSUserDefaults standardUserDefaults] objectForKey:feature.key])
+ enabled = [[NSUserDefaults standardUserDefaults] boolForKey:feature.key];
+ else
+ enabled = [feature defaultValue];
[configuration.preferences _setEnabled:enabled forInternalDebugFeature:feature];
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
