Title: [236600] trunk/Source/WebCore
- Revision
- 236600
- Author
- [email protected]
- Date
- 2018-09-28 10:04:04 -0700 (Fri, 28 Sep 2018)
Log Message
Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
https://bugs.webkit.org/show_bug.cgi?id=190077
<rdar://problem/44812613>
Reviewed by Zalan Bujtas.
Drop iOS specific quirk in SettingsBase::scriptEnabledChanged() that would dirty style after the
"_javascript_Enabled" setting's state is toggled. I do not see a good reason to do this given that
scripts would not get executed until a reload.
If we find out after dropping this that this is actually useful for some reason, then we can
always bring it back and consider making this non-iOS specific, as well as documenting why this
it is needed.
* page/Settings.yaml:
* page/SettingsBase.cpp:
(WebCore::SettingsBase::scriptEnabledChanged): Deleted.
* page/SettingsBase.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (236599 => 236600)
--- trunk/Source/WebCore/ChangeLog 2018-09-28 15:56:54 UTC (rev 236599)
+++ trunk/Source/WebCore/ChangeLog 2018-09-28 17:04:04 UTC (rev 236600)
@@ -1,3 +1,24 @@
+2018-09-28 Chris Dumez <[email protected]>
+
+ Drop iOS specific quirk in SettingsBase::scriptEnabledChanged()
+ https://bugs.webkit.org/show_bug.cgi?id=190077
+ <rdar://problem/44812613>
+
+ Reviewed by Zalan Bujtas.
+
+ Drop iOS specific quirk in SettingsBase::scriptEnabledChanged() that would dirty style after the
+ "_javascript_Enabled" setting's state is toggled. I do not see a good reason to do this given that
+ scripts would not get executed until a reload.
+
+ If we find out after dropping this that this is actually useful for some reason, then we can
+ always bring it back and consider making this non-iOS specific, as well as documenting why this
+ it is needed.
+
+ * page/Settings.yaml:
+ * page/SettingsBase.cpp:
+ (WebCore::SettingsBase::scriptEnabledChanged): Deleted.
+ * page/SettingsBase.h:
+
2018-09-27 Basuke Suzuki <[email protected]>
[Curl] Fix priority issue with multiple cookies with different level of path.
Modified: trunk/Source/WebCore/page/Settings.yaml (236599 => 236600)
--- trunk/Source/WebCore/page/Settings.yaml 2018-09-28 15:56:54 UTC (rev 236599)
+++ trunk/Source/WebCore/page/Settings.yaml 2018-09-28 17:04:04 UTC (rev 236600)
@@ -655,7 +655,6 @@
scriptEnabled:
initial: false
getter: isScriptEnabled
- onChange: scriptEnabledChanged
pluginsEnabled:
initial: false
getter: arePluginsEnabled
Modified: trunk/Source/WebCore/page/SettingsBase.cpp (236599 => 236600)
--- trunk/Source/WebCore/page/SettingsBase.cpp 2018-09-28 15:56:54 UTC (rev 236599)
+++ trunk/Source/WebCore/page/SettingsBase.cpp 2018-09-28 17:04:04 UTC (rev 236600)
@@ -292,15 +292,6 @@
}
}
-void SettingsBase::scriptEnabledChanged()
-{
-#if PLATFORM(IOS)
- // FIXME: Why do we only do this on iOS?
- if (m_page)
- m_page->setNeedsRecalcStyleInAllFrames();
-#endif
-}
-
void SettingsBase::pluginsEnabledChanged()
{
Page::refreshPlugins(false);
Modified: trunk/Source/WebCore/page/SettingsBase.h (236599 => 236600)
--- trunk/Source/WebCore/page/SettingsBase.h 2018-09-28 15:56:54 UTC (rev 236599)
+++ trunk/Source/WebCore/page/SettingsBase.h 2018-09-28 17:04:04 UTC (rev 236600)
@@ -178,7 +178,6 @@
void setNeedsRelayoutAllFrames();
void mediaTypeOverrideChanged();
void imagesEnabledChanged();
- void scriptEnabledChanged();
void pluginsEnabledChanged();
void userStyleSheetLocationChanged();
void usesPageCacheChanged();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
