Title: [236641] trunk/Source/WebKit
Revision
236641
Author
[email protected]
Date
2018-09-29 02:49:31 -0700 (Sat, 29 Sep 2018)

Log Message

[PSON] Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage()
https://bugs.webkit.org/show_bug.cgi?id=190084
<rdar://problem/44844561>

Reviewed by Antti Koivisto.

Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage(), as a
result of calling WebPage::tearDownDrawingAreaForSuspend().

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (236640 => 236641)


--- trunk/Source/WebKit/ChangeLog	2018-09-29 09:43:00 UTC (rev 236640)
+++ trunk/Source/WebKit/ChangeLog	2018-09-29 09:49:31 UTC (rev 236641)
@@ -1,3 +1,17 @@
+2018-09-29  Chris Dumez  <[email protected]>
+
+        [PSON] Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage()
+        https://bugs.webkit.org/show_bug.cgi?id=190084
+        <rdar://problem/44844561>
+
+        Reviewed by Antti Koivisto.
+
+        Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage(), as a
+        result of calling WebPage::tearDownDrawingAreaForSuspend().
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
+
 2018-09-28  Wenson Hsieh  <[email protected]>
 
         No DOM API to instantiate an attachment for an img element

Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (236640 => 236641)


--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2018-09-29 09:43:00 UTC (rev 236640)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2018-09-29 09:49:31 UTC (rev 236641)
@@ -1441,7 +1441,8 @@
     m_frame->coreFrame()->view()->setProhibitsScrolling(shouldDisableScrolling);
     m_frame->coreFrame()->view()->setVisualUpdatesAllowedByClient(!webPage->shouldExtendIncrementalRenderingSuppression());
 #if PLATFORM(COCOA)
-    m_frame->coreFrame()->view()->setViewExposedRect(webPage->drawingArea()->viewExposedRect());
+    if (webPage->drawingArea())
+        m_frame->coreFrame()->view()->setViewExposedRect(webPage->drawingArea()->viewExposedRect());
 #endif
 #if PLATFORM(IOS)
     m_frame->coreFrame()->view()->setDelegatesScrolling(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to