Diff
Modified: trunk/LayoutTests/ChangeLog (236643 => 236644)
--- trunk/LayoutTests/ChangeLog 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/LayoutTests/ChangeLog 2018-09-29 17:40:17 UTC (rev 236644)
@@ -1,3 +1,18 @@
+2018-09-29 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r236631.
+ https://bugs.webkit.org/show_bug.cgi?id=190112
+
+ Caused various eventSender tests, including fast/css/pseudo-
+ active-style-sharing*, to fail (Requested by smfr on #webkit).
+
+ Reverted changeset:
+
+ "Regression(r236512): http/tests/navigation/keyboard-events-
+ during-provisional-navigation.html is flaky"
+ https://bugs.webkit.org/show_bug.cgi?id=190052
+ https://trac.webkit.org/changeset/236631
+
2018-09-28 Zamiul Haque <[email protected]>
Angled gradient backgrounds in body render vertically when body height is 0
Modified: trunk/LayoutTests/fast/forms/file/input-file-write-files-using-open-panel.html (236643 => 236644)
--- trunk/LayoutTests/fast/forms/file/input-file-write-files-using-open-panel.html 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/LayoutTests/fast/forms/file/input-file-write-files-using-open-panel.html 2018-09-29 17:40:17 UTC (rev 236644)
@@ -18,9 +18,8 @@
file1.addEventListener("change", function() {
file2.addEventListener("change", function() {
- setTimeout(() => {
- runTest(file1, file2);
- }, 0);
+ runTest(file1, file2);
+ finishJSTest();
});
window.setTimeout(function() {
dragFilesOntoInput(file2, ["bar.txt"]);
@@ -44,8 +43,6 @@
file1.files = file2.files;
shouldBe("file1.files.length", "1");
shouldBeEqualToString("file1.files.item(0).name", "bar.txt");
-
- finishJSTest();
}
function dragFilesOntoInput(input, files) {
Modified: trunk/Source/WebKit/ChangeLog (236643 => 236644)
--- trunk/Source/WebKit/ChangeLog 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/ChangeLog 2018-09-29 17:40:17 UTC (rev 236644)
@@ -1,3 +1,18 @@
+2018-09-29 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r236631.
+ https://bugs.webkit.org/show_bug.cgi?id=190112
+
+ Caused various eventSender tests, including fast/css/pseudo-
+ active-style-sharing*, to fail (Requested by smfr on #webkit).
+
+ Reverted changeset:
+
+ "Regression(r236512): http/tests/navigation/keyboard-events-
+ during-provisional-navigation.html is flaky"
+ https://bugs.webkit.org/show_bug.cgi?id=190052
+ https://trac.webkit.org/changeset/236631
+
2018-09-29 Chris Dumez <[email protected]>
[PSON] Deal with the drawing area potentially being null in WebFrameLoaderClient::transitionToCommittedForNewPage()
Modified: trunk/Source/WebKit/Platform/IPC/Connection.cpp (236643 => 236644)
--- trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/Platform/IPC/Connection.cpp 2018-09-29 17:40:17 UTC (rev 236644)
@@ -400,7 +400,7 @@
if (!isValid())
return false;
- if (isMainThread() && m_inDispatchMessageMarkedToUseFullySynchronousModeForTesting && !encoder->isSyncMessage() && !(encoder->messageReceiverName() == "IPC") && !sendOptions.contains(SendOption::IgnoreFullySynchronousMode)) {
+ if (isMainThread() && m_inDispatchMessageMarkedToUseFullySynchronousModeForTesting && !encoder->isSyncMessage() && !(encoder->messageReceiverName() == "IPC")) {
uint64_t syncRequestID;
auto wrappedMessage = createSyncMessageEncoder("IPC", "WrappedAsyncMessageForTesting", encoder->destinationID(), syncRequestID);
wrappedMessage->setFullySynchronousModeForTesting();
Modified: trunk/Source/WebKit/Platform/IPC/Connection.h (236643 => 236644)
--- trunk/Source/WebKit/Platform/IPC/Connection.h 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/Platform/IPC/Connection.h 2018-09-29 17:40:17 UTC (rev 236644)
@@ -61,7 +61,6 @@
// Whether this message should be dispatched when waiting for a sync reply.
// This is the default for synchronous messages.
DispatchMessageEvenWhenWaitingForSyncReply = 1 << 0,
- IgnoreFullySynchronousMode = 1 << 1,
};
enum class SendSyncOption {
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp (236643 => 236644)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp 2018-09-29 17:40:17 UTC (rev 236644)
@@ -665,11 +665,6 @@
toImpl(pageRef)->postMessage(toWTFString(messageNameRef), toImpl(messageBodyRef));
}
-void WKBundlePagePostMessageIgnoringFullySynchronousMode(WKBundlePageRef pageRef, WKStringRef messageNameRef, WKTypeRef messageBodyRef)
-{
- toImpl(pageRef)->postMessageIgnoringFullySynchronousMode(toWTFString(messageNameRef), toImpl(messageBodyRef));
-}
-
void WKBundlePagePostSynchronousMessageForTesting(WKBundlePageRef pageRef, WKStringRef messageNameRef, WKTypeRef messageBodyRef, WKTypeRef* returnDataRef)
{
WebPage* page = toImpl(pageRef);
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h (236643 => 236644)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.h 2018-09-29 17:40:17 UTC (rev 236644)
@@ -124,8 +124,6 @@
// Switches a connection into a fully synchronous mode, so all messages become synchronous until we get a response.
WK_EXPORT void WKBundlePagePostSynchronousMessageForTesting(WKBundlePageRef page, WKStringRef messageName, WKTypeRef messageBody, WKTypeRef* returnData);
-// Same as WKBundlePagePostMessage() but the message cannot become synchronous, even if the connection is in fully synchronous mode.
-WK_EXPORT void WKBundlePagePostMessageIgnoringFullySynchronousMode(WKBundlePageRef page, WKStringRef messageName, WKTypeRef messageBody);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (236643 => 236644)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2018-09-29 17:40:17 UTC (rev 236644)
@@ -5828,11 +5828,6 @@
send(Messages::WebPageProxy::HandleMessage(messageName, UserData(WebProcess::singleton().transformObjectsToHandles(messageBody))));
}
-void WebPage::postMessageIgnoringFullySynchronousMode(const String& messageName, API::Object* messageBody)
-{
- send(Messages::WebPageProxy::HandleMessage(messageName, UserData(WebProcess::singleton().transformObjectsToHandles(messageBody))), pageID(), IPC::SendOption::IgnoreFullySynchronousMode);
-}
-
void WebPage::postSynchronousMessageForTesting(const String& messageName, API::Object* messageBody, RefPtr<API::Object>& returnData)
{
UserData returnUserData;
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.h (236643 => 236644)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.h 2018-09-29 17:40:17 UTC (rev 236644)
@@ -1014,7 +1014,6 @@
void postMessage(const String& messageName, API::Object* messageBody);
void postSynchronousMessageForTesting(const String& messageName, API::Object* messageBody, RefPtr<API::Object>& returnData);
- void postMessageIgnoringFullySynchronousMode(const String& messageName, API::Object* messageBody);
#if PLATFORM(GTK)
void setInputMethodState(bool);
Modified: trunk/Tools/ChangeLog (236643 => 236644)
--- trunk/Tools/ChangeLog 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Tools/ChangeLog 2018-09-29 17:40:17 UTC (rev 236644)
@@ -1,3 +1,18 @@
+2018-09-29 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r236631.
+ https://bugs.webkit.org/show_bug.cgi?id=190112
+
+ Caused various eventSender tests, including fast/css/pseudo-
+ active-style-sharing*, to fail (Requested by smfr on #webkit).
+
+ Reverted changeset:
+
+ "Regression(r236512): http/tests/navigation/keyboard-events-
+ during-provisional-navigation.html is flaky"
+ https://bugs.webkit.org/show_bug.cgi?id=190052
+ https://trac.webkit.org/changeset/236631
+
2018-09-28 Myles C. Maxfield <[email protected]>
[WHLSL] Fix build after r236635
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (236643 => 236644)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2018-09-29 12:11:17 UTC (rev 236643)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp 2018-09-29 17:40:17 UTC (rev 236644)
@@ -603,10 +603,7 @@
return;
WKRetainPtr<WKStringRef> messageName(AdoptWK, WKStringCreateWithUTF8CString("TextOutput"));
WKRetainPtr<WKStringRef> messageBody(AdoptWK, WKStringCreateWithUTF8CString(output.utf8().data()));
- // We use WKBundlePagePostMessageIgnoringFullySynchronousMode() instead of WKBundlePagePostMessage() to make sure that all text output
- // is done via asynchronous IPC, even if the connection is in fully synchronous mode due to a WKBundlePagePostSynchronousMessageForTesting()
- // call. Otherwise, messages logged via sync and async IPC may end up out of order and cause flakiness.
- WKBundlePagePostMessageIgnoringFullySynchronousMode(page()->page(), messageName.get(), messageBody.get());
+ WKBundlePagePostMessage(page()->page(), messageName.get(), messageBody.get());
}
void InjectedBundle::postNewBeforeUnloadReturnValue(bool value)
