Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236647 => 236648)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-09-30 22:07:45 UTC (rev 236648)
@@ -1,3 +1,12 @@
+2018-09-30 Walker Henderson <[email protected]>
+
+ AudioNode.connect should return passed destination node
+ https://bugs.webkit.org/show_bug.cgi?id=188834
+
+ Reviewed by Eric Carlson.
+
+ * web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt:
+
2018-09-29 Oriol Brufau <[email protected]>
[css-grid] Properly align items next to collapsed tracks with gutters
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt (236647 => 236648)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-return-value-expected.txt 2018-09-30 22:07:45 UTC (rev 236648)
@@ -1,3 +1,3 @@
-FAIL connect should return the node connected to. assert_equals: expected (object) object "[object GainNode]" but got (undefined) undefined
+PASS connect should return the node connected to.
Modified: trunk/Source/WebCore/ChangeLog (236647 => 236648)
--- trunk/Source/WebCore/ChangeLog 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/ChangeLog 2018-09-30 22:07:45 UTC (rev 236648)
@@ -1,3 +1,19 @@
+2018-09-30 Walker Henderson <[email protected]>
+
+ AudioNode.connect should return passed destination node
+ https://bugs.webkit.org/show_bug.cgi?id=188834
+
+ Reviewed by Eric Carlson.
+
+ No new tests, rebaselined existing test.
+
+ * Modules/webaudio/AudioBasicInspectorNode.cpp:
+ (WebCore::AudioBasicInspectorNode::connect): Deleted.
+ * Modules/webaudio/AudioBasicInspectorNode.h:
+ * Modules/webaudio/AudioNode.cpp:
+ * Modules/webaudio/AudioNode.h:
+ * Modules/webaudio/AudioNode.idl:
+
2018-09-30 Eric Carlson <[email protected]>
[MediaStream] Clean up RealtimeMediaSource settings change handling
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp (236647 => 236648)
--- trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.cpp 2018-09-30 22:07:45 UTC (rev 236648)
@@ -49,7 +49,7 @@
input(0)->pull(output(0)->bus(), framesToProcess);
}
-ExceptionOr<void> AudioBasicInspectorNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
+ExceptionOr<AudioNode&> AudioBasicInspectorNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
{
ASSERT(isMainThread());
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h (236647 => 236648)
--- trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicInspectorNode.h 2018-09-30 22:07:45 UTC (rev 236648)
@@ -37,7 +37,7 @@
private:
void pullInputs(size_t framesToProcess) override;
- ExceptionOr<void> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex) override;
+ ExceptionOr<AudioNode&> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex) override;
ExceptionOr<void> disconnect(unsigned outputIndex) override;
void checkNumberOfChannelsForInput(AudioNodeInput*) override;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp (236647 => 236648)
--- trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.cpp 2018-09-30 22:07:45 UTC (rev 236648)
@@ -122,7 +122,7 @@
return nullptr;
}
-ExceptionOr<void> AudioNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
+ExceptionOr<AudioNode&> AudioNode::connect(AudioNode& destination, unsigned outputIndex, unsigned inputIndex)
{
ASSERT(isMainThread());
AudioContext::AutoLocker locker(context());
@@ -144,7 +144,7 @@
// Let context know that a connection has been made.
context().incrementConnectionCount();
- return { };
+ return destination;
}
ExceptionOr<void> AudioNode::connect(AudioParam& param, unsigned outputIndex)
Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.h (236647 => 236648)
--- trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2018-09-30 22:07:45 UTC (rev 236648)
@@ -123,7 +123,7 @@
AudioNodeOutput* output(unsigned);
// Called from main thread by corresponding _javascript_ methods.
- virtual ExceptionOr<void> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex);
+ virtual ExceptionOr<AudioNode&> connect(AudioNode&, unsigned outputIndex, unsigned inputIndex);
ExceptionOr<void> connect(AudioParam&, unsigned outputIndex);
virtual ExceptionOr<void> disconnect(unsigned outputIndex);
Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.idl (236647 => 236648)
--- trunk/Source/WebCore/Modules/webaudio/AudioNode.idl 2018-09-30 18:18:55 UTC (rev 236647)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.idl 2018-09-30 22:07:45 UTC (rev 236648)
@@ -34,7 +34,7 @@
attribute DOMString channelCountMode;
attribute DOMString channelInterpretation;
- [MayThrowException] void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
+ [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
[MayThrowException] void connect(AudioParam destination, optional unsigned long output = 0);
[MayThrowException] void disconnect(optional unsigned long output = 0);
};
