Title: [236673] trunk
- Revision
- 236673
- Author
- commit-qu...@webkit.org
- Date
- 2018-10-01 11:08:35 -0700 (Mon, 01 Oct 2018)
Log Message
<form> in quirks mode should have margin-block-end: 1em
https://bugs.webkit.org/show_bug.cgi?id=157788
Patch by Simon Pieters <zcor...@gmail.com> on 2018-10-01
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html: Added.
* web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt: Added.
Source/WebCore:
Change the default style for forms to take writing-mode into account
in quirks mode. Matches the behavior of Gecko and Edge and the HTML
standard.
Spec: https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3
Test: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html
* css/quirks.css:
(form):
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236672 => 236673)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-01 18:06:41 UTC (rev 236672)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-10-01 18:08:35 UTC (rev 236673)
@@ -1,3 +1,13 @@
+2018-10-01 Simon Pieters <zcor...@gmail.com>
+
+ <form> in quirks mode should have margin-block-end: 1em
+ https://bugs.webkit.org/show_bug.cgi?id=157788
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html: Added.
+ * web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt: Added.
+
2018-10-01 Rob Buis <rb...@igalia.com>
Align XMLHttpRequest's overrideMimeType() with the standard
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt (0 => 236673)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk-expected.txt 2018-10-01 18:08:35 UTC (rev 236673)
@@ -0,0 +1,3 @@
+
+PASS form margin quirk
+
Added: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html (0 => 236673)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html (rev 0)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html 2018-10-01 18:08:35 UTC (rev 236673)
@@ -0,0 +1,20 @@
+<!-- quirks -->
+<title>form margin quirk</title>
+<script src=""
+<script src=""
+<style>
+form { writing-mode: vertical-lr; }
+#ref { margin: 0 1em 0 0; }
+</style>
+<form id=form></form>
+<div id=ref></div>
+<script>
+test(() => {
+ const formStyle = getComputedStyle(document.getElementById('form'));
+ const refStyle = getComputedStyle(document.getElementById('ref'));
+ assert_equals(formStyle.marginTop, refStyle.marginTop, 'marginTop');
+ assert_equals(formStyle.marginRight, refStyle.marginRight, 'marginRight');
+ assert_equals(formStyle.marginBottom, refStyle.marginBottom, 'marginBottom');
+ assert_equals(formStyle.marginLeft, refStyle.marginLeft, 'marginLeft');
+});
+</script>
Modified: trunk/Source/WebCore/ChangeLog (236672 => 236673)
--- trunk/Source/WebCore/ChangeLog 2018-10-01 18:06:41 UTC (rev 236672)
+++ trunk/Source/WebCore/ChangeLog 2018-10-01 18:08:35 UTC (rev 236673)
@@ -1,3 +1,21 @@
+2018-10-01 Simon Pieters <zcor...@gmail.com>
+
+ <form> in quirks mode should have margin-block-end: 1em
+ https://bugs.webkit.org/show_bug.cgi?id=157788
+
+ Reviewed by Simon Fraser.
+
+ Change the default style for forms to take writing-mode into account
+ in quirks mode. Matches the behavior of Gecko and Edge and the HTML
+ standard.
+
+ Spec: https://html.spec.whatwg.org/multipage/rendering.html#flow-content-3
+
+ Test: imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/form-margin-quirk.html
+
+ * css/quirks.css:
+ (form):
+
2018-10-01 Jeremy Jones <jere...@apple.com>
Unify implementation in VideoFullscreenInterfaceAVKit
Modified: trunk/Source/WebCore/css/quirks.css (236672 => 236673)
--- trunk/Source/WebCore/css/quirks.css 2018-10-01 18:06:41 UTC (rev 236672)
+++ trunk/Source/WebCore/css/quirks.css 2018-10-01 18:08:35 UTC (rev 236673)
@@ -1,4 +1,4 @@
-/*
+/*
* Additonal style sheet used to render HTML pages in quirks mode.
*
* Copyright (C) 2000-2003 Lars Knoll (kn...@kde.org)
@@ -50,5 +50,5 @@
/* Set margin-bottom for form element in quirks mode. */
/* Compatible with Gecko. (Doing this only for quirks mode is a fix for bug 17696.) */
form {
- margin-bottom: 1em
+ margin-block-end: 1em
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
