Title: [236681] releases/WebKitGTK/webkit-2.22/Source/WebCore
Revision
236681
Author
[email protected]
Date
2018-10-01 12:17:10 -0700 (Mon, 01 Oct 2018)

Log Message

Merge r236395 - [MSE][GStreamer] Don't update duration when it was not previously NaN
https://bugs.webkit.org/show_bug.cgi?id=189869

Reviewed by Xabier Rodriguez-Calvar.

This is what the spec mandates. The spec doesn't say anything about
updating duration when it had been previously set, even if the new
init segment says that the duration is growing.

This fixes MSE YTTV 2018 69.MediaSourceDurationVP9.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog (236680 => 236681)


--- releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2018-10-01 18:57:02 UTC (rev 236680)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/ChangeLog	2018-10-01 19:17:10 UTC (rev 236681)
@@ -1,3 +1,19 @@
+2018-09-24  Enrique Ocaña González  <[email protected]>
+
+        [MSE][GStreamer] Don't update duration when it was not previously NaN
+        https://bugs.webkit.org/show_bug.cgi?id=189869
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This is what the spec mandates. The spec doesn't say anything about
+        updating duration when it had been previously set, even if the new
+        init segment says that the duration is growing.
+
+        This fixes MSE YTTV 2018 69.MediaSourceDurationVP9.
+
+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
+        (WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):
+
 2018-08-30  Ross Kirsling  <[email protected]>
 
         Speculative build fix for WPE after r235531.

Modified: releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp (236680 => 236681)


--- releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2018-10-01 18:57:02 UTC (rev 236680)
+++ releases/WebKitGTK/webkit-2.22/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp	2018-10-01 19:17:10 UTC (rev 236681)
@@ -1005,8 +1005,7 @@
     }
 #endif
 
-    if (m_initialDuration > m_mediaSourceClient->duration()
-        || (m_mediaSourceClient->duration().isInvalid() && m_initialDuration > MediaTime::zeroTime()))
+    if (m_mediaSourceClient->duration().isInvalid() && m_initialDuration > MediaTime::zeroTime())
         m_mediaSourceClient->durationChanged(m_initialDuration);
 
     parseDemuxerSrcPadCaps(gst_caps_ref(caps.get()));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to