Diff
Modified: trunk/LayoutTests/ChangeLog (236787 => 236788)
--- trunk/LayoutTests/ChangeLog 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/ChangeLog 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,3 +1,29 @@
+2018-10-03 Ryosuke Niwa <[email protected]>
+
+ Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=190238
+
+ Reviewed by Antti Koivisto.
+
+ Removed the unnecessary webkit-test-runner directive.
+
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-1.html:
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-2.html:
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-3.html:
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-4.html:
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html:
+ * editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html:
+ * editing/pasteboard/copy-paste-with-shadow-content.html:
+ * editing/selection/selection-across-shadow-boundaries-mixed-editability-1.html:
+ * editing/selection/selection-across-shadow-boundaries-mixed-editability-2.html:
+ * editing/selection/selection-across-shadow-boundaries-mixed-editability-3.html:
+ * editing/selection/selection-across-shadow-boundaries-mixed-editability-4.html:
+ * editing/selection/selection-across-shadow-boundaries-mixed-editability-5.html:
+ * editing/selection/selection-across-shadow-boundaries-readonly-1.html:
+ * editing/selection/selection-across-shadow-boundaries-readonly-2.html:
+ * editing/selection/selection-across-shadow-boundaries-readonly-3.html:
+ * editing/selection/selection-across-shadow-boundaries-user-select-all-1.html:
+
2018-10-02 Fujii Hironori <[email protected]>
[WinCairo][BuildBot] archive-test-results fails to delete pywebsocket.ws.log-err.txt
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-1.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-1.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-1.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-2.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-2.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-2.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-3.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-3.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-3.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-4.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-4.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-4.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-1.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-across-shadow-boundaries-with-style-2.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content across shadow boundaries.<br>
Modified: trunk/LayoutTests/editing/pasteboard/copy-paste-with-shadow-content.html (236787 => 236788)
--- trunk/LayoutTests/editing/pasteboard/copy-paste-with-shadow-content.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/pasteboard/copy-paste-with-shadow-content.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p id="description">This tests copying and pasting content with a shadow tree.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-1.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-1.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-1.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in an editable element to a shadow tree.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-2.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-2.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-2.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in a shadow tree out to an editable element.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-3.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-3.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-3.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in an editable region in a shadow tree to an editable region in the document tree.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-4.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-4.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-4.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in a shadow tree inside an editable region to the outside.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-5.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-5.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-mixed-editability-5.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in a shadow tree inside a non-editable region in an editable region to outside the editable region.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-1.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-1.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-1.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in the document into a shadow tree.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-2.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-2.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-2.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in a shadow tree out to the document.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-3.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-3.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-readonly-3.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in one shadow tree and ending another shadow tree.<br>
Modified: trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-user-select-all-1.html (236787 => 236788)
--- trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-user-select-all-1.html 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/LayoutTests/editing/selection/selection-across-shadow-boundaries-user-select-all-1.html 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ internal:selectionAcrossShadowBoundariesEnabled=true ] -->
+<!DOCTYPE html>
<html>
<body>
<p>This tests selecting content starting in a shadow tree inside a <code>user-select: all</code> in an editable region in to outside the editable region.<br>
Modified: trunk/Source/WebCore/ChangeLog (236787 => 236788)
--- trunk/Source/WebCore/ChangeLog 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Source/WebCore/ChangeLog 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,3 +1,14 @@
+2018-10-03 Ryosuke Niwa <[email protected]>
+
+ Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=190238
+
+ Reviewed by Antti Koivisto.
+
+ Enable the feature by default.
+
+ * page/Settings.yaml:
+
2018-10-02 Ryosuke Niwa <[email protected]>
Copying content with shadow DOM doesn't copy any contents
Modified: trunk/Source/WebCore/page/Settings.yaml (236787 => 236788)
--- trunk/Source/WebCore/page/Settings.yaml 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Source/WebCore/page/Settings.yaml 2018-10-03 09:45:18 UTC (rev 236788)
@@ -390,7 +390,7 @@
selectTrailingWhitespaceEnabled:
initial: defaultSelectTrailingWhitespaceEnabled
selectionAcrossShadowBoundariesEnabled:
- initial: false
+ initial: true
useLegacyBackgroundSizeShorthandBehavior:
initial: false
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (236787 => 236788)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,3 +1,15 @@
+2018-10-03 Ryosuke Niwa <[email protected]>
+
+ Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=190238
+
+ Reviewed by Antti Koivisto.
+
+ Enabled the feature by default.
+
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+
2018-10-01 Dean Jackson <[email protected]>
[macOS] Switching to discrete GPU should be done in the UI process
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (236787 => 236788)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2018-10-03 09:45:18 UTC (rev 236788)
@@ -663,7 +663,7 @@
#if ENABLE(WEB_RTC)
[NSNumber numberWithBool:YES], WebKitPeerConnectionEnabledPreferenceKey,
#endif
- [NSNumber numberWithBool:NO], WebKitSelectionAcrossShadowBoundariesEnabledPreferenceKey,
+ [NSNumber numberWithBool:YES], WebKitSelectionAcrossShadowBoundariesEnabledPreferenceKey,
#if ENABLE(INTERSECTION_OBSERVER)
@NO, WebKitIntersectionObserverEnabledPreferenceKey,
#endif
Modified: trunk/Tools/ChangeLog (236787 => 236788)
--- trunk/Tools/ChangeLog 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Tools/ChangeLog 2018-10-03 09:45:18 UTC (rev 236788)
@@ -1,3 +1,14 @@
+2018-10-03 Ryosuke Niwa <[email protected]>
+
+ Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
+ https://bugs.webkit.org/show_bug.cgi?id=190238
+
+ Reviewed by Antti Koivisto.
+
+ * DumpRenderTree/TestOptions.h:
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+
2018-10-02 Wenson Hsieh <[email protected]>
[WebKit2] Format > Bold and Format > Italic don't toggle between bold and italic style
Modified: trunk/Tools/DumpRenderTree/TestOptions.h (236787 => 236788)
--- trunk/Tools/DumpRenderTree/TestOptions.h 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Tools/DumpRenderTree/TestOptions.h 2018-10-03 09:45:18 UTC (rev 236788)
@@ -43,7 +43,7 @@
bool dumpJSConsoleLogInStdErr { false };
bool allowCrossOriginSubresourcesToAskForCredentials { false };
bool enableColorFilter { false };
- bool enableSelectionAcrossShadowBoundaries { false };
+ bool enableSelectionAcrossShadowBoundaries { true };
std::string jscOptions;
TestOptions(const std::string& pathOrURL, const std::string& absolutePath);
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (236787 => 236788)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2018-10-03 07:08:48 UTC (rev 236787)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2018-10-03 09:45:18 UTC (rev 236788)
@@ -989,7 +989,7 @@
[preferences setCacheAPIEnabled:NO];
preferences.mediaCapabilitiesEnabled = YES;
- preferences.selectionAcrossShadowBoundariesEnabled = NO;
+ preferences.selectionAcrossShadowBoundariesEnabled = YES;
[WebPreferences _clearNetworkLoaderSession];
[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain];
