Title: [236802] trunk
Revision
236802
Author
[email protected]
Date
2018-10-03 11:23:53 -0700 (Wed, 03 Oct 2018)

Log Message

Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener
https://bugs.webkit.org/show_bug.cgi?id=190251

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:

Source/WebCore:

Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener,
similarly to noopener=1:
- https://html.spec.whatwg.org/#window-open-steps (step 5)

It does not matter what the value is, if there is a key named "noopener", then the new window
should not have an opener.

No new tests, rebaselined existing test.

* page/WindowFeatures.cpp:
(WebCore::setWindowFeature):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (236801 => 236802)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-10-03 18:16:39 UTC (rev 236801)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-10-03 18:23:53 UTC (rev 236802)
@@ -1,5 +1,16 @@
 2018-10-03  Chris Dumez  <[email protected]>
 
+        Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener
+        https://bugs.webkit.org/show_bug.cgi?id=190251
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline WPT test now that it is passing.
+
+        * web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
+
+2018-10-03  Chris Dumez  <[email protected]>
+
         input.checked is incorrect while we're parsing its children
         https://bugs.webkit.org/show_bug.cgi?id=190227
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt (236801 => 236802)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt	2018-10-03 18:16:39 UTC (rev 236801)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt	2018-10-03 18:23:53 UTC (rev 236802)
@@ -1,10 +1,9 @@
 
 PASS tokenization should skip window features separators before `name` 
-FAIL feature `name` should be converted to ASCII lowercase assert_equals: "noopener=NOOPENER" should activate feature "noopener" expected null but got object "[object Window]"
+PASS feature `name` should be converted to ASCII lowercase 
 PASS after `name`, tokenization should skip window features separators that are not "=" or "," 
-FAIL Tokenizing should ignore window feature separators except "," after initial "=" and before value assert_equals: "noopener
-=\r noopener," should activate feature "noopener" expected null but got object "[object Window]"
-FAIL Tokenizing should read characters until first window feature separator as `value` assert_equals: "noopener=noopener" should set "noopener" expected null but got object "[object Window]"
-FAIL "noopener" should be based on name (key), not value assert_equals: "noopener=false" should activate feature "noopener" expected null but got object "[object Window]"
+PASS Tokenizing should ignore window feature separators except "," after initial "=" and before value 
+PASS Tokenizing should read characters until first window feature separator as `value` 
+PASS "noopener" should be based on name (key), not value 
 PASS invalid feature names should not tokenize as "noopener" 
 

Modified: trunk/Source/WebCore/ChangeLog (236801 => 236802)


--- trunk/Source/WebCore/ChangeLog	2018-10-03 18:16:39 UTC (rev 236801)
+++ trunk/Source/WebCore/ChangeLog	2018-10-03 18:23:53 UTC (rev 236802)
@@ -1,3 +1,22 @@
+2018-10-03  Chris Dumez  <[email protected]>
+
+        Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener
+        https://bugs.webkit.org/show_bug.cgi?id=190251
+
+        Reviewed by Alex Christensen.
+
+        Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener,
+        similarly to noopener=1:
+        - https://html.spec.whatwg.org/#window-open-steps (step 5)
+
+        It does not matter what the value is, if there is a key named "noopener", then the new window
+        should not have an opener.
+
+        No new tests, rebaselined existing test.
+
+        * page/WindowFeatures.cpp:
+        (WebCore::setWindowFeature):
+
 2018-10-03  Ryosuke Niwa  <[email protected]>
 
         GC can collect JS wrappers of nodes in the mutation records waiting to be delivered

Modified: trunk/Source/WebCore/page/WindowFeatures.cpp (236801 => 236802)


--- trunk/Source/WebCore/page/WindowFeatures.cpp	2018-10-03 18:16:39 UTC (rev 236801)
+++ trunk/Source/WebCore/page/WindowFeatures.cpp	2018-10-03 18:23:53 UTC (rev 236802)
@@ -158,7 +158,7 @@
     else if (equalLettersIgnoringASCIICase(key, "scrollbars"))
         features.scrollbarsVisible = numericValue;
     else if (equalLettersIgnoringASCIICase(key, "noopener"))
-        features.noopener = numericValue;
+        features.noopener = true;
     else if (numericValue == 1)
         features.additionalFeatures.append(key.toString());
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to