Title: [101664] trunk/Source/WebCore
- Revision
- 101664
- Author
- [email protected]
- Date
- 2011-12-01 07:10:04 -0800 (Thu, 01 Dec 2011)
Log Message
run-bindings-tests is failing on Gtk/Qt/SnowLeopard/Lion bots
https://bugs.webkit.org/show_bug.cgi?id=73558
Reviewed by Csaba Osztrogonác.
The cause of the bug:
foreach my $idlFile (keys %documents) {
$supplementals{$idlFile} = [];
foreach my $dataNode (...) {
if (...) {
...;
push(@{$supplementals{$targetIdlFile}}, $idlFile);
...;
}
}
}
Even if we did push(@{$supplementals{$targetIdlFile}}, $idlFile),
the $supplementals{$targetIdlFile} can be re-initialized by
$supplementals{$idlFile} = [] in subsequent loops.
This patch fixes the bug.
Tests: bindings/scripts/test/TestInterface.idl
* bindings/scripts/resolve-supplemental.pl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (101663 => 101664)
--- trunk/Source/WebCore/ChangeLog 2011-12-01 13:45:54 UTC (rev 101663)
+++ trunk/Source/WebCore/ChangeLog 2011-12-01 15:10:04 UTC (rev 101664)
@@ -1,3 +1,32 @@
+2011-12-01 Kentaro Hara <[email protected]>
+
+ run-bindings-tests is failing on Gtk/Qt/SnowLeopard/Lion bots
+ https://bugs.webkit.org/show_bug.cgi?id=73558
+
+ Reviewed by Csaba Osztrogonác.
+
+ The cause of the bug:
+
+ foreach my $idlFile (keys %documents) {
+ $supplementals{$idlFile} = [];
+ foreach my $dataNode (...) {
+ if (...) {
+ ...;
+ push(@{$supplementals{$targetIdlFile}}, $idlFile);
+ ...;
+ }
+ }
+ }
+
+ Even if we did push(@{$supplementals{$targetIdlFile}}, $idlFile),
+ the $supplementals{$targetIdlFile} can be re-initialized by
+ $supplementals{$idlFile} = [] in subsequent loops.
+ This patch fixes the bug.
+
+ Tests: bindings/scripts/test/TestInterface.idl
+
+ * bindings/scripts/resolve-supplemental.pl:
+
2011-12-01 Pavel Feldman <[email protected]>
Web Inspector: restore WebKit2 Safari menu items after capabilities refactoring regression.
Modified: trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl (101663 => 101664)
--- trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl 2011-12-01 13:45:54 UTC (rev 101663)
+++ trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl 2011-12-01 15:10:04 UTC (rev 101664)
@@ -65,6 +65,8 @@
my %supplementals;
foreach my $idlFile (keys %documents) {
$supplementals{$idlFile} = [];
+}
+foreach my $idlFile (keys %documents) {
foreach my $dataNode (@{$documents{$idlFile}->classes}) {
if ($dataNode->extendedAttributes->{"Supplemental"}) {
my $targetIdlFile = $interfaceNameToIdlFile{$dataNode->extendedAttributes->{"Supplemental"}};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
