Title: [236827] trunk/Source/_javascript_Core
- Revision
- 236827
- Author
- [email protected]
- Date
- 2018-10-03 22:12:19 -0700 (Wed, 03 Oct 2018)
Log Message
[JSC] print() changes CRLF to CRCRLF on Windows
https://bugs.webkit.org/show_bug.cgi?id=190228
Reviewed by Mark Lam.
* jsc.cpp:
(main):
Ultimately, this is just the normal behavior of printf in text mode on Windows.
Since we're reading in files as binary, we need to be printing out as binary too
(just as we do in DumpRenderTree and ImageDiff.)
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (236826 => 236827)
--- trunk/Source/_javascript_Core/ChangeLog 2018-10-04 04:57:35 UTC (rev 236826)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-10-04 05:12:19 UTC (rev 236827)
@@ -1,3 +1,16 @@
+2018-10-03 Ross Kirsling <[email protected]>
+
+ [JSC] print() changes CRLF to CRCRLF on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=190228
+
+ Reviewed by Mark Lam.
+
+ * jsc.cpp:
+ (main):
+ Ultimately, this is just the normal behavior of printf in text mode on Windows.
+ Since we're reading in files as binary, we need to be printing out as binary too
+ (just as we do in DumpRenderTree and ImageDiff.)
+
2018-10-03 Saam barati <[email protected]>
lowXYZ in FTLLower should always filter the type of the incoming edge
Modified: trunk/Source/_javascript_Core/jsc.cpp (236826 => 236827)
--- trunk/Source/_javascript_Core/jsc.cpp 2018-10-04 04:57:35 UTC (rev 236826)
+++ trunk/Source/_javascript_Core/jsc.cpp 2018-10-04 05:12:19 UTC (rev 236827)
@@ -90,6 +90,8 @@
#if OS(WINDOWS)
#include <direct.h>
+#include <fcntl.h>
+#include <io.h>
#include <wtf/text/win/WCharStringExtras.h>
#else
#include <unistd.h>
@@ -2231,6 +2233,9 @@
// error mode here to work around Cygwin's behavior. See <http://webkit.org/b/55222>.
::SetErrorMode(0);
+ _setmode(_fileno(stdout), _O_BINARY);
+ _setmode(_fileno(stderr), _O_BINARY);
+
#if defined(_DEBUG)
_CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR);
_CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
