Diff
Modified: trunk/LayoutTests/ChangeLog (236836 => 236837)
--- trunk/LayoutTests/ChangeLog 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/LayoutTests/ChangeLog 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,3 +1,16 @@
+2018-10-04 Chris Dumez <[email protected]>
+
+ Unreviewed, rolling out r236803.
+
+ Caused crashes on some bots
+
+ Reverted changeset:
+
+ "Regression(r236779): Crash when changing the input element
+ type from inside an 'input' event listener"
+ https://bugs.webkit.org/show_bug.cgi?id=190252
+ https://trac.webkit.org/changeset/236803
+
2018-10-03 Justin Michaud <[email protected]>
Registered custom properties should allow inheritance to be controlled
Deleted: trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener-expected.txt (236836 => 236837)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener-expected.txt 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener-expected.txt 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,10 +0,0 @@
-Make sure we do not crash if the 'click' event listener changes the input type.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Click event was fired
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener.html (236836 => 236837)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener.html 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-click-event-listener.html 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,28 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script>
-description("Make sure we do not crash if the 'click' event listener changes the input type.");
-
-_onload_ = () => {
- testInput.addEventListener("click", () => {
- testPassed("Click event was fired");
- testInput.type = "text";
- });
-
- testInput.addEventListener("input", () => {
- testFailed("input event should not have fired");
- });
- testInput.addEventListener("change", () => {
- testFailed("change event should not have fired");
- });
- testInput.click();
- setTimeout(finishJSTest, 0);
-};
-</script>
-<input type="checkbox" id="testInput"></input>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener-expected.txt (236836 => 236837)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener-expected.txt 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener-expected.txt 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,10 +0,0 @@
-Make sure we do not crash if the 'input' event listener changes the input type.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Input event was fired
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener.html (236836 => 236837)
--- trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener.html 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/LayoutTests/fast/dom/HTMLInputElement/change-type-in-input-event-listener.html 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script>
-description("Make sure we do not crash if the 'input' event listener changes the input type.");
-
-_onload_ = () => {
- testInput.addEventListener("input", () => {
- testPassed("Input event was fired");
- testInput.type = "text";
- });
- testInput.addEventListener("change", () => {
- testFailed("change event should not have fired");
- });
- testInput.click();
- setTimeout(finishJSTest, 0);
-};
-</script>
-<input type="checkbox" id="testInput"></input>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (236836 => 236837)
--- trunk/Source/WebCore/ChangeLog 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/Source/WebCore/ChangeLog 2018-10-04 17:52:42 UTC (rev 236837)
@@ -1,3 +1,16 @@
+2018-10-04 Chris Dumez <[email protected]>
+
+ Unreviewed, rolling out r236803.
+
+ Caused crashes on some bots
+
+ Reverted changeset:
+
+ "Regression(r236779): Crash when changing the input element
+ type from inside an 'input' event listener"
+ https://bugs.webkit.org/show_bug.cgi?id=190252
+ https://trac.webkit.org/changeset/236803
+
2018-10-04 Dan Bernstein <[email protected]>
Tried to fix the Mojave build after r236832.
Modified: trunk/Source/WebCore/html/BaseCheckableInputType.cpp (236836 => 236837)
--- trunk/Source/WebCore/html/BaseCheckableInputType.cpp 2018-10-04 17:34:22 UTC (rev 236836)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.cpp 2018-10-04 17:52:42 UTC (rev 236837)
@@ -129,8 +129,7 @@
element()->setTextAsOfLastFormControlChangeEvent(String());
element()->dispatchInputEvent();
- if (auto* element = this->element())
- element->dispatchFormControlChangeEvent();
+ element()->dispatchFormControlChangeEvent();
}
} // namespace WebCore
