Title: [236879] trunk/Source/WebKit
Revision
236879
Author
[email protected]
Date
2018-10-05 11:26:56 -0700 (Fri, 05 Oct 2018)

Log Message

[PSON] Drop snapshotting workaround introduced in r235898
https://bugs.webkit.org/show_bug.cgi?id=190314

Reviewed by Geoffrey Garen.

Drop snapshotting workaround introduced in r235898 as it is no longer needed now
that the flashing bug has been fixed.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::continueNavigationInNewProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (236878 => 236879)


--- trunk/Source/WebKit/ChangeLog	2018-10-05 17:35:44 UTC (rev 236878)
+++ trunk/Source/WebKit/ChangeLog	2018-10-05 18:26:56 UTC (rev 236879)
@@ -1,3 +1,16 @@
+2018-10-05  Chris Dumez  <[email protected]>
+
+        [PSON] Drop snapshotting workaround introduced in r235898
+        https://bugs.webkit.org/show_bug.cgi?id=190314
+
+        Reviewed by Geoffrey Garen.
+
+        Drop snapshotting workaround introduced in r235898 as it is no longer needed now
+        that the flashing bug has been fixed.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::continueNavigationInNewProcess):
+
 2018-10-05  Eric Carlson  <[email protected]>
 
         [MediaStream] RealtimeMediaSource should be able to vend hashed IDs

Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236878 => 236879)


--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-10-05 17:35:44 UTC (rev 236878)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2018-10-05 18:26:56 UTC (rev 236879)
@@ -2536,12 +2536,6 @@
 {
     LOG(Loading, "Continuing navigation %" PRIu64 " '%s' in a new web process", navigation.navigationID(), navigation.loggingString());
 
-    // Because we're about to tear down the drawing area and swap to a new process, this is our last opportunity to snapshot what's currently displayed before
-    // we navigate. Do the navigation snapshot now and suppress the next one since the view will be blank then.
-    // FIXME: We should be able to drop this logic if we kept displaying the previous content a while longer when we swap process on navigation.
-    recordAutomaticNavigationSnapshot();
-    suppressNextAutomaticNavigationSnapshot();
-
     Ref<WebProcessProxy> previousProcess = m_process.copyRef();
     std::optional<uint64_t> navigatedFrameIdentifierInPreviousProcess;
     if (m_mainFrame)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to