Title: [236886] trunk/Source/WebKit
- Revision
- 236886
- Author
- [email protected]
- Date
- 2018-10-05 14:39:57 -0700 (Fri, 05 Oct 2018)
Log Message
REGRESSION(r236154) Page loads are not drawn when loaded in shipped Safari11/12
https://bugs.webkit.org/show_bug.cgi?id=190202
Reviewed by Youenn Fablet.
Safari11/12 had a WKPageLoaderClient and a WKPageNavigationClient.
It did not actually draw the page until its WKPageNavigationClient.renderingProgressDidChange was called.
r236154 made it so we only call WKPageLoaderClient.didLayout if an application has both clients.
This fixes open source WebKit running with shipped Safari.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReachLayoutMilestone):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (236885 => 236886)
--- trunk/Source/WebKit/ChangeLog 2018-10-05 21:12:48 UTC (rev 236885)
+++ trunk/Source/WebKit/ChangeLog 2018-10-05 21:39:57 UTC (rev 236886)
@@ -1,3 +1,18 @@
+2018-10-05 Alex Christensen <[email protected]>
+
+ REGRESSION(r236154) Page loads are not drawn when loaded in shipped Safari11/12
+ https://bugs.webkit.org/show_bug.cgi?id=190202
+
+ Reviewed by Youenn Fablet.
+
+ Safari11/12 had a WKPageLoaderClient and a WKPageNavigationClient.
+ It did not actually draw the page until its WKPageNavigationClient.renderingProgressDidChange was called.
+ r236154 made it so we only call WKPageLoaderClient.didLayout if an application has both clients.
+ This fixes open source WebKit running with shipped Safari.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::didReachLayoutMilestone):
+
2018-10-05 Chris Dumez <[email protected]>
[PSON] Drop snapshotting workaround introduced in r235898
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (236885 => 236886)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-10-05 21:12:48 UTC (rev 236885)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-10-05 21:39:57 UTC (rev 236886)
@@ -3993,8 +3993,7 @@
if (m_loaderClient)
m_loaderClient->didReachLayoutMilestone(*this, static_cast<LayoutMilestones>(layoutMilestones));
- else
- m_navigationClient->renderingProgressDidChange(*this, static_cast<LayoutMilestones>(layoutMilestones));
+ m_navigationClient->renderingProgressDidChange(*this, static_cast<LayoutMilestones>(layoutMilestones));
}
void WebPageProxy::didDisplayInsecureContentForFrame(uint64_t frameID, const UserData& userData)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
