Diff
Modified: trunk/Source/WebKit/ChangeLog (236901 => 236902)
--- trunk/Source/WebKit/ChangeLog 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/ChangeLog 2018-10-07 01:29:52 UTC (rev 236902)
@@ -1,3 +1,32 @@
+2018-10-06 Dan Bernstein <[email protected]>
+
+ WebKit part of [Xcode] Update some build settings as recommended by Xcode 10
+ https://bugs.webkit.org/show_bug.cgi?id=190250
+
+ Reviewed by Andy Estes.
+
+ * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
+ CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and
+ CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
+
+ * WebKit.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
+
+ * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+ * UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
+ * UIProcess/API/Cocoa/WKConnection.mm:
+ * UIProcess/API/Cocoa/WKNavigationData.mm:
+ * UIProcess/API/Cocoa/WKProcessGroup.mm:
+ * UIProcess/API/Cocoa/WKTypeRefWrapper.mm:
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ * UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:
+ * UIProcess/API/mac/WKView.mm:
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ * WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
+
+ Suppressed -Wdeprecated-implementations around some class, category and method
+ implementations the above files.
+
2018-10-05 Alex Christensen <[email protected]>
REGRESSION(r236154) Page loads are not drawn when loaded in shipped Safari11/12
Modified: trunk/Source/WebKit/Configurations/Base.xcconfig (236901 => 236902)
--- trunk/Source/WebKit/Configurations/Base.xcconfig 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/Configurations/Base.xcconfig 2018-10-07 01:29:52 UTC (rev 236902)
@@ -35,6 +35,7 @@
CLANG_ENABLE_OBJC_WEAK = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
+CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_CXX0X_EXTENSIONS = NO;
CLANG_WARN_EMPTY_BODY = YES;
@@ -74,8 +75,11 @@
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_NON_VIRTUAL_DESTRUCTOR = YES;
+CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
GCC_WARN_SIGN_COMPARE = YES;
GCC_WARN_UNDECLARED_SELECTOR = YES;
+CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
+CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -72,7 +72,9 @@
NSString * const WKActionOriginatingFrameURLKey = @"WKActionOriginatingFrameURLKey";
NSString * const WKActionCanShowMIMETypeKey = @"WKActionCanShowMIMETypeKey";
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKBrowsingContextController {
+IGNORE_WARNINGS_END
RefPtr<WebKit::WebPageProxy> _page;
std::unique_ptr<WebKit::PageLoadStateObserver> _pageLoadStateObserver;
@@ -618,7 +620,9 @@
@end
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKBrowsingContextController (Private)
+IGNORE_WARNINGS_END
- (WKPageRef)_pageRef
{
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextGroup.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -42,7 +42,9 @@
#import "WKURLCF.h"
#import <wtf/Vector.h>
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKBrowsingContextGroup {
+IGNORE_WARNINGS_END
API::ObjectStorage<WebKit::WebPageGroup> _pageGroup;
}
@@ -176,7 +178,9 @@
@end
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKBrowsingContextGroup (Private)
+IGNORE_WARNINGS_END
- (WKPageGroupRef)_pageGroupRef
{
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKConnection.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -36,7 +36,9 @@
#import <wtf/WeakObjCPtr.h>
#import <wtf/text/WTFString.h>
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKConnection {
+IGNORE_WARNINGS_END
WeakObjCPtr<id <WKConnectionDelegate>> _delegate;
}
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationData.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -32,7 +32,9 @@
#import <WebCore/ResourceRequest.h>
#import <WebCore/ResourceResponse.h>
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKNavigationData {
+IGNORE_WARNINGS_END
API::ObjectStorage<API::NavigationData> _data;
}
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessGroup.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -52,7 +52,9 @@
#import <WebCore/WebCoreThreadSystemInterface.h>
#endif
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKProcessGroup {
+IGNORE_WARNINGS_END
RefPtr<WebKit::WebProcessPool> _processPool;
WeakObjCPtr<id <WKProcessGroupDelegate>> _delegate;
@@ -220,7 +222,9 @@
@end
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKProcessGroup (Private)
+IGNORE_WARNINGS_END
- (WKContextRef)_contextRef
{
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKTypeRefWrapper.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -36,7 +36,9 @@
}
@end
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKTypeRefWrapper
+IGNORE_WARNINGS_END
- (id)initWithObject:(WKTypeRef)object
{
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -3295,7 +3295,9 @@
_impl->setFrameSize(NSSizeToCGSize(size));
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)renewGState
+IGNORE_WARNINGS_END
{
_impl->renewGState();
[super renewGState];
@@ -3789,7 +3791,9 @@
}
#if ENABLE(DRAG_SUPPORT)
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
+IGNORE_WARNINGS_END
{
_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
}
@@ -3880,7 +3884,9 @@
return _impl->accessibilityFocusedUIElement();
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsIgnored
+IGNORE_WARNINGS_END
{
return _impl->accessibilityIsIgnored();
}
@@ -3890,7 +3896,9 @@
return _impl->accessibilityHitTest(NSPointToCGPoint(point));
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute
+IGNORE_WARNINGS_END
{
return _impl->accessibilityAttributeValue(attribute);
}
@@ -3960,7 +3968,9 @@
_impl->provideDataForPasteboard(pasteboard, type);
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
+IGNORE_WARNINGS_END
{
return _impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
}
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -502,12 +502,16 @@
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (_WKWebsiteDataStore *)_websiteDataStore
+IGNORE_WARNINGS_END
{
return self.websiteDataStore ? adoptNS([[_WKWebsiteDataStore alloc] initWithDataStore:self.websiteDataStore]).autorelease() : nullptr;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)_setWebsiteDataStore:(_WKWebsiteDataStore *)websiteDataStore
+IGNORE_WARNINGS_END
{
self.websiteDataStore = websiteDataStore ? websiteDataStore->_dataStore.get() : nullptr;
}
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStore.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -42,7 +42,9 @@
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation _WKWebsiteDataStore
+IGNORE_WARNINGS_END
- (instancetype)initWithDataStore:(WKWebsiteDataStore *)dataStore
{
Modified: trunk/Source/WebKit/UIProcess/API/mac/WKView.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/API/mac/WKView.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/API/mac/WKView.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -70,7 +70,9 @@
#endif
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKView
+IGNORE_WARNINGS_END
#if WK_API_ENABLED
@@ -180,7 +182,9 @@
_data->_impl->setFrameSize(NSSizeToCGSize(size));
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)renewGState
+IGNORE_WARNINGS_END
{
_data->_impl->renewGState();
[super renewGState];
@@ -693,7 +697,9 @@
}
#if ENABLE(DRAG_SUPPORT)
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)draggedImage:(NSImage *)image endedAt:(NSPoint)endPoint operation:(NSDragOperation)operation
+IGNORE_WARNINGS_END
{
_data->_impl->draggedImage(image, NSPointToCGPoint(endPoint), operation);
}
@@ -784,7 +790,9 @@
return _data->_impl->accessibilityFocusedUIElement();
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsIgnored
+IGNORE_WARNINGS_END
{
return _data->_impl->accessibilityIsIgnored();
}
@@ -794,7 +802,9 @@
return _data->_impl->accessibilityHitTest(NSPointToCGPoint(point));
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute
+IGNORE_WARNINGS_END
{
return _data->_impl->accessibilityAttributeValue(attribute);
}
@@ -864,7 +874,9 @@
_data->_impl->provideDataForPasteboard(pasteboard, type);
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)namesOfPromisedFilesDroppedAtDestination:(NSURL *)dropDestination
+IGNORE_WARNINGS_END
{
return _data->_impl->namesOfPromisedFilesDroppedAtDestination(dropDestination);
}
@@ -1121,7 +1133,9 @@
@end
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
@implementation WKView (Private)
+IGNORE_WARNINGS_END
- (void)saveBackForwardSnapshotForCurrentItem
{
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -73,7 +73,9 @@
[super dealloc];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
+IGNORE_WARNINGS_END
{
if (popoverController != _popoverController)
return;
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -465,7 +465,9 @@
#pragma mark - UIPopoverControllerDelegate
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
+IGNORE_WARNINGS_END
{
[self _cancel];
}
@@ -486,7 +488,9 @@
#pragma mark - UIDocumentPickerControllerDelegate implementation
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)documentPicker:(UIDocumentPickerViewController *)documentPicker didPickDocumentAtURL:(NSURL *)url
+IGNORE_WARNINGS_END
{
[self _dismissDisplayAnimated:YES];
[self _chooseFiles:@[url] displayString:url.lastPathComponent iconImage:iconForFile(url)];
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm (236901 => 236902)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFormPopover.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -167,7 +167,9 @@
[self presentPopoverAnimated:NO];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)popoverControllerDidDismissPopover:(UIPopoverController *)popoverController
+IGNORE_WARNINGS_END
{
if (_isRotating)
return;
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (236901 => 236902)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-10-07 01:29:52 UTC (rev 236902)
@@ -9984,7 +9984,7 @@
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 0700;
- LastUpgradeCheck = 0700;
+ LastUpgradeCheck = 1000;
TargetAttributes = {
E1AC2E2720F7B94C00B0897D = {
CreatedOnToolsVersion = 9.3;
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (236901 => 236902)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -161,7 +161,9 @@
#endif
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsIgnored
+IGNORE_WARNINGS_END
{
return NO;
}
@@ -172,7 +174,9 @@
return _pdfPlugin->convertFromPDFViewToScreen(rect);
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute
+IGNORE_WARNINGS_END
{
if ([attribute isEqualToString:NSAccessibilityParentAttribute])
return _parent;
@@ -214,7 +218,9 @@
return 0;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
+IGNORE_WARNINGS_END
{
if ([attribute isEqualToString:NSAccessibilityBoundsForRangeParameterizedAttribute]) {
NSRect boundsInPDFViewCoordinates = [[_pdfLayerController accessibilityBoundsForRangeAttributeForParameter:parameter] rectValue];
@@ -237,7 +243,9 @@
return [_pdfLayerController readingModel];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityAttributeNames
+IGNORE_WARNINGS_END
{
static NSArray *attributeNames = 0;
@@ -269,7 +277,9 @@
return attributeNames;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityActionNames
+IGNORE_WARNINGS_END
{
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
return nil;
@@ -283,23 +293,31 @@
#endif
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)accessibilityPerformAction:(NSString *)action
+IGNORE_WARNINGS_END
{
if ([action isEqualToString:NSAccessibilityShowMenuAction])
_pdfPlugin->showContextMenuAtPoint(WebCore::IntRect(WebCore::IntPoint(), _pdfPlugin->size()).center());
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
+IGNORE_WARNINGS_END
{
return [_pdfLayerController accessibilityIsAttributeSettable:attribute];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
+IGNORE_WARNINGS_END
{
return [_pdfLayerController accessibilitySetValue:value forAttribute:attribute];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityParameterizedAttributeNames
+IGNORE_WARNINGS_END
{
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300
return nil;
Modified: trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm (236901 => 236902)
--- trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2018-10-07 00:20:59 UTC (rev 236901)
+++ trunk/Source/WebKit/WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm 2018-10-07 01:29:52 UTC (rev 236902)
@@ -60,12 +60,16 @@
[super dealloc];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsIgnored
+IGNORE_WARNINGS_END
{
return NO;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityAttributeNames
+IGNORE_WARNINGS_END
{
if (!m_attributeNames)
m_attributeNames = adoptNS([[NSArray alloc] initWithObjects:
@@ -76,7 +80,9 @@
return m_attributeNames.get();
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityParameterizedAttributeNames
+IGNORE_WARNINGS_END
{
Vector<String> result = m_page->corePage()->pageOverlayController().copyAccessibilityAttributesNames(true);
if (result.isEmpty())
@@ -89,12 +95,16 @@
return names;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (BOOL)accessibilityIsAttributeSettable:(NSString *)attribute
+IGNORE_WARNINGS_END
{
return NO;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (void)accessibilitySetValue:(id)value forAttribute:(NSString *)attribute
+IGNORE_WARNINGS_END
{
}
@@ -103,7 +113,9 @@
return m_page->screenToRootView(IntPoint(point.x, point.y));
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (NSArray *)accessibilityActionNames
+IGNORE_WARNINGS_END
{
return [NSArray array];
}
@@ -117,7 +129,9 @@
return [NSArray arrayWithObject:wrapper];
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute
+IGNORE_WARNINGS_END
{
if (!WebCore::AXObjectCache::accessibilityEnabled())
WebCore::AXObjectCache::enableAccessibility();
@@ -162,7 +176,9 @@
return nil;
}
+IGNORE_WARNINGS_BEGIN("deprecated-implementations")
- (id)accessibilityAttributeValue:(NSString *)attribute forParameter:(id)parameter
+IGNORE_WARNINGS_END
{
WebCore::FloatPoint pageOverlayPoint;
if ([parameter isKindOfClass:[NSValue class]] && !strcmp([(NSValue *)parameter objCType], @encode(NSPoint)))
